Incompatibility with Party module (throws Notice: Undefined index: party_attaching_party in views_natural_sort_get_supported_entity_properties())

@lionguard

Thanks for the patch. For future reference, there is an approved workflow for patches using git. If you don't have git, (or did like you did and happened to have 2 copies of the same module), consider still using the patch name format of [project_name]-[short-description]-[issue-number]-[comment-number].patch.

For those who work on sites professionally, this does a lot for documenting where to find updated information on patches in our drush make files, composer.json, PATCHES folder, or PATCHES.TXT, as that format gives us specifically the issue number and comment number.

Thank you for keeping the patch in a -p1 format as well. That helped out a lot.

Lastly, When you submit a patch, move the issue to "needs review" if possible.

With all that said, the real problem here was there is an array_merge above. it was clobbering the existing property values with what was supposed to be the property defaults. So in this case... every $property_info['type'] was "text". Since it was overloading party module's property info type (which was "party") with text, we were making it down to the next line where we were trying to get info from the "User" table for the schema field "party_attaching_party". Clearly it does not have that field because the "Party" type property is handled differently.

You will want to undo your patch on your local code as views natural sort will most likely not be working for you at all.

Test out the patch I worked up and let me know if it gets rid of your notices.

went ahead and committed this one. give me a heads up if you see anything else. specific to the error "Notice: Undefined index: party_attaching_party in views_natural_sort_get_supported_entity_properties()"

Never mind.

You should also get the fix in 2.2. Shouldn't need the development release.

Understood. I thought the error I had went away but it did not. My mistake.

I am getting this:

Notice: Undefined index: vuuid in views_natural_sort_get_supported_entity_properties() (line 333 of /var/www/blog/sites/all/modules/views_natural_sort/views_natural_sort.module).

But I have not looked deeply into. I was going to add in an isset in there somewhere before line 333 to see if I could take care of it. Not sure where vuuid is even coming from.

Also seeing this:

Notice: Undefined property: stdClass::$name in views_natural_sort_entity_to_vns() (line 405 of /var/www/blog/sites/all/modules/views_natural_sort/views_natural_sort.module).

Again, not sure where from.

Can you please create separate issues for your new notices? you are starting to use this issue as a catch all for notices and the point was to look into the party module.

We can follow up on additional questions in the repective issues for #10 & #11 since it's clearly a different module causing the behavior. Specifically for #10... one that produces a entity with vuuid.

Appreciate it tons.

Will do.