Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
In CheckboxTest::testFormCheckbox()
there are two loops over XPath queries. These loops never actually execute because JSON is returned instead of HTML.
Comment | File | Size | Author |
---|---|---|---|
#4 | 2667358-4.patch | 3.77 KB | twistor |
#2 | 2667358-2.patch | 1.91 KB | twistor |
#2 | 2667358-2-test-only-should-fail.patch | 1.16 KB | twistor |
Comments
Comment #2
twistor CreditAttribution: twistor as a volunteer commentedComment #4
twistor CreditAttribution: twistor as a volunteer commentedI think it would be better to be explicit with the json parameter. No need for defaults.
Comment #6
daffie CreditAttribution: daffie commentedI have reviewed the patch and it all looks good to me.
1. The adding of the explicit json parameter is making the test more clear to me.
2. The change from
has('json')
toget('json')
looks a bit strange to me. But with the double test patch from comment #2 proves that the change is good and necessary.Good work twistor.
Comment #7
alexpottCommitted f813708 and pushed to 8.1.x and 8.2.x. Thanks!