API page: https://api.drupal.org/api/drupal/core!modules!system!templates!vertical...

> children: The rendered checkboxes.

Doesn't look right. Vertical tabs contain more than checkboxes, surely?

CommentFileSizeAuthor
#6 2667304-6.patch1.31 KBfelribeiro
#3 2667304-3.patch1.31 KBfelribeiro
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim created an issue. See original summary.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Issue tags: +Novice

Yes, that was probably left over from a copy/paste.

Propose changing it to

The rendered tabs.

Note that there are 3 versions of this template file in Core. All 3 need the fix most likely.

felribeiro’s picture

felribeiro CreditAttribution: felribeiro at CI&T commented
Status: Active » Needs review
FileSize
2667304-3.patch1.31 KB
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Reviewed & tested by the community

In general, when you are making patches for an issue, PLEASE assign it to yourself until it is done. It is very annoying when multiple people come and go on issues, and leaving it assigned indicates you will (hopefully) come back and fix any problems with the patch. Thanks!

In this case, the patch is fine so no need to go back and assign it now. Thanks! Good patch.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Title: error in variables documentation for vertical-tabs.html.twig » Error in variables documentation for vertical-tabs.html.twig
Version: 8.0.x-dev » 8.1.x-dev
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs re-roll

hmm I feel the opposite to #4 about the assigned field. Someone being assigned to an issue who isn't actively working on the patch at the moment can discourage other people from helping with re-rolling the patch for conflicts or other review issues.

Needs a re-roll for 8.1.x

felribeiro’s picture

felribeiro CreditAttribution: felribeiro at CI&T commented
Status: Needs work » Needs review
FileSize
2667304-6.patch1.31 KB

Patch to 8.1.x-dev

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Needs review » Reviewed & tested by the community

Thanks.

  • catch committed e578fd9 on 8.1.x 
    Issue #2667304 by felribeiro: Error in variables documentation for...

  • catch committed 390369c on 8.0.x 
    Issue #2667304 by felribeiro: Error in variables documentation for...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 8.1.x-dev » 8.0.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.1.x and 8.0.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.