The documentation to theme_node clearly says the the parameter $teaser is "Whether to display the teaser only, as on the main page." Naming this parameter $main in the themes is confusing. Main is used elsewhere to mean "whether to show full view or teaser view", but the meaning of $teaser seems to be subtly different.
An alternate to the patch I'm suggesting would be to eliminate $teaser altogether, system-wide. The variable $main makes it clear that it is transmitting state (whether or not on the node's main page), whereas the variable $teaser makes on think it is transmitting the actual teaser.
Comment | File | Size | Author |
---|---|---|---|
#6 | phptemplate_engine_patch.txt | 1.54 KB | robertDouglass |
#4 | main_teaser2.patch.txt | 3.16 KB | robertDouglass |
main_teaser.patch.txt | 3.1 KB | robertDouglass |
Comments
Comment #1
Thox CreditAttribution: Thox commentedI don't follow your logic why $teaser needs to be renamed, especially if $main is the alternative. If RSS wants to only show the teaser, does $main=true make sense?
Comment #2
Bèr Kessels CreditAttribution: Bèr Kessels commented+1 from me. It removes another variable. and it increases the logic. Instaed of using inversed logic, we now all use one single variable.
Comment #3
Thox CreditAttribution: Thox commentedI must have been half asleep. It does make sense, and it is logical.
+1
Comment #4
robertDouglass CreditAttribution: robertDouglass commentedUpdated so that it still applies.
Comment #5
Dries CreditAttribution: Dries commentedCommitted to HEAD. Thanks. Please update the theme migration documentation. Thanks.
Comment #6
robertDouglass CreditAttribution: robertDouglass commentedThe change to phptemplate.engine didn't get made.
Comment #7
Dries CreditAttribution: Dries commentedCommitted to HEAD. Thanks.
Comment #8
(not verified) CreditAttribution: commentedComment #9
(not verified) CreditAttribution: commentedComment #10
(not verified) CreditAttribution: commentedComment #11
(not verified) CreditAttribution: commentedComment #12
(not verified) CreditAttribution: commented