I’m guessing with this, but it did confuse me when I was trying to work out how to register a theme_hook().

CommentFileSizeAuthor
themeing.patch674 byteszeta ζ
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Steven Jones’s picture

Project: Documentation » Drupal core
Version: » 7.x-dev
Component: Documentation in CVS » documentation

Wrong queue.

Patch looks okay visually, though maybe more extensive changes are required to make things more clear?

zeta ζ’s picture

Maybe – though I’ll leave that to someone who knows what it is, that should be made clear. This patch makes it clear enough not to confuse me, which is all I wanted to avoid for the next person viewing the docs.

I thought it was fairly obvious that the wrong word was used unintentionally, rather than the original author was being unclear, so I didn’t attempt a rewrite.

Any suggestions?

If you would rather leave this as obviously wrong in order to encourage someone to rewrite the rest of it then I will have to wait.
I was trying to use the documentation to learn what the answer should be, rather than trying to spot errors.

Steven Jones’s picture

Status: Needs review » Reviewed & tested by the community

Yup, fair point.

chx’s picture

Status: Reviewed & tested by the community » Needs work

The theme hook should be deprecated because the registry already parses the file...

chx’s picture

Status: Needs work » Reviewed & tested by the community

Erm no the theme hook has parameters and template/function informations, sorry.

Dries’s picture

Version: 7.x-dev » 6.x-dev

Committed to CVS HEAD. Updating version.

Gábor Hojtsy’s picture

Status: Reviewed & tested by the community » Fixed

Thanks, committed to D6.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.