Problem/Motivation

If a user makes any modifications to ./.eslintrc it can be difficult and time consuming to merge the changes from core into your custom file.

Proposed resolution

  1. Move ./.eslintrc into ./core/.eslintrc
  2. Create a new ./.eslintrc that simply extends the ./core/.eslintrc file.

This allows the user to always have a clean config file. It allows core to make all the changes they'd like without the user having to merge those changes.

The new ./.eslintrc would look something like this:

{
  "extends": "./core/.eslintrc"
}

A user can add override any rules they'd like by adding them to this file.

Remaining tasks

  1. Write Patch

User interface changes

None.

API changes

None.

Data model changes

None.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

davidwbarratt created an issue. See original summary.

nod_’s picture

wanted to do that for a while. +1

Wim Leers’s picture

Sounds great!

naveenvalecha’s picture

Status: Active » Needs review
FileSize
3.03 KB

Initial patch

naveenvalecha’s picture

nod_’s picture

Status: Needs review » Reviewed & tested by the community

Eslint still working as before. Thanks.

  • alexpott committed c867ce3 on 8.1.x
    Issue #2660034 by naveenvalecha: Move .eslintrc into core/.eslintrc
    

  • alexpott committed addd898 on
    Issue #2660034 by naveenvalecha: Move .eslintrc into core/.eslintrc
    
    (...
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed addd898 and pushed to 8.0.x and 8.1.x. Thanks!

Whilst this is not a bug it is a test infrastructure only based change therefore permitted to 8.0.x and no rules have changed either.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.