Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
In the core/includes/form.inc, @return doc block is wrongly added to a function returning nothing.
Proposed resolution
Remove the @return doc
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#8 | removing_wrongly_added-2659524-8.patch | 740 bytes | gaydabura |
Comments
Comment #2
rakesh.gectcrComment #3
David Hernández CreditAttribution: David Hernández as a volunteer commentedConfirmed. The function doesn't return anything.
Comment #4
jhodgdonTrue, it shouldn't be a @return. But ... we seem to be losing some information that should still be in the documentation somewhere?
Comment #5
gaydabura CreditAttribution: gaydabura as a volunteer and at Skilld commentedComment #6
andypostLooks good, when batch passed by reference there's no other way to update its set
Comment #7
jhodgdonThanks for the patch! It needs a little fix though:
If this is meant to be two paragraphs, you need to leave a blank line between them.
If it is meant to be one paragraph, you need to rewrap so that each docs line is as close to 80 characters as possible without going over.
Also moving this to 8.0.x to indicate it should be committed to both 8.0 and 8.1 branches. And fixing the title/summary since this is about a wrong @return, not @param.
Comment #8
gaydabura CreditAttribution: gaydabura as a volunteer and at Skilld commentedthnx @jhodgdon
new patch is attached
Comment #9
gaydabura CreditAttribution: gaydabura as a volunteer and at Skilld commentedComment #10
Devaraj johnson CreditAttribution: Devaraj johnson as a volunteer and at Ameex-Drupal Geeks commentedComment #11
jhodgdonGood enough, thanks!
Comment #12
catchCommitted/pushed to 8.1.x and cherry-picked to 8.0.x. Thanks!