* @return \Drupal\Core\Entity\EntityInterface
   *   Returns the entity matching the values.
   */
  public function getEntity(ResultRow $values);

Looking at the code for the implementation, this can also return NULL.

CommentFileSizeAuthor
#7 D8-getEntity-return-NULL-2657826-7.patch815 byteser.pushpinderrana
#5 D8-getEntity-return-NULL-2657826-5.patch784 byteser.pushpinderrana
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim created an issue. See original summary.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Related issues: +#2609432: Improve docblocks for views FieldHandlerInterface.php

Adding related issue

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

vinod_kc’s picture

vinod_kc CreditAttribution: vinod_kc at Zyxware Technologies commented
Assigned: Unassigned » vinod_kc
er.pushpinderrana’s picture

er.pushpinderrana CreditAttribution: er.pushpinderrana as a volunteer and at Publicis Sapient for Publicis Sapient commented
Assigned: vinod_kc » Unassigned
Status: Active » Needs review
FileSize
D8-getEntity-return-NULL-2657826-5.patch784 bytes

Please review.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Needs work
Issue tags: -needs backport to 8.0.x

Thanks for the patch!

+++ b/core/modules/views/src/Plugin/views/field/FieldHandlerInterface.php
@@ -116,8 +116,8 @@ public function elementWrapperClasses($row_index = NULL);
+   *   Returns the entity matching the values, otherwise NULL.

This wording seems a bit odd to me. Maybe at the end something like:

or NULL if there is no matching entity.

would be clearer?

er.pushpinderrana’s picture

er.pushpinderrana CreditAttribution: er.pushpinderrana as a volunteer and at Publicis Sapient for Publicis Sapient commented
Status: Needs work » Needs review
FileSize
D8-getEntity-return-NULL-2657826-7.patch815 bytes

Thank you! Updated your suggestion in this patch.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Reviewed & tested by the community

That looks better to me. Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

I think the null typehint should be at the end - it is the less common case.

Committed a9d0778 and pushed to 8.1.x and 8.2.x. Thanks!

  • alexpott committed a9d0778 on 8.1.x 
    Issue #2657826 by er.pushpinderrana: FieldHandlerInterface::getEntity()...

  • alexpott committed 322e96f on 8.2.x 
    Issue #2657826 by er.pushpinderrana: FieldHandlerInterface::getEntity()...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Related issues: +#2715483: [regression] getEntity() doesn't always return entity, which results in add comment field not working in Views