submitAjaxFacetSourceConfigForm breaks machine_name validation.

A similar issue: https://www.drupal.org/node/2657674. The same steps to reproduce (but in facets context).

Patch is attached.

CommentFileSizeAuthor
#4 facets-facets_facet_already_exists-2657706-4.patch2.74 KBalan-ps
facets-facets_facet_already_exists.patch445 bytesalan-ps
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alan-ps created an issue. See original summary.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ for Acquia commented

Is it possible to write a regression test for this?

alan-ps’s picture

alan-ps CreditAttribution: alan-ps commented
Assigned: Unassigned » alan-ps

sure, I will look at issue on this weekend.

alan-ps’s picture

alan-ps CreditAttribution: alan-ps commented
Assigned: alan-ps » Unassigned
FileSize
facets-facets_facet_already_exists-2657706-4.patch2.74 KB

New patch with an appropriate test case.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ for Acquia commented
Status: Needs review » Reviewed & tested by the community

Awesome, the test looks great. I'm assuming the test-only will be red, just as the search api one is?

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ for Acquia commented
Priority: Major » Normal
Status: Reviewed & tested by the community » Fixed

Comitted and pushed, thanks for the issue and the patch.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ for Acquia commented
Issue tags: +SprintWeekend2016

Adding tag.

  • borisson_ committed 3a0de31 on 8.x-1.x authored by alan-ps 
    Issue #2657706 by alan-ps: Drupal\Core\Entity\EntityStorageException: '...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.