The query string url processor can't handle a colon in the value. We fixed a similar issue for the key in #2640746: Query string url processor can't handle a colon in the key..

The unwanted char is colon with the default url processor, but what we really want to exclude is any character used as a separator for the current UrlProcessor class.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

borisson_ created an issue. See original summary.

borisson_’s picture

Issue tags: +Needs committer feedback
FileSize
2.37 KB
borisson_’s picture

Status: Active Β» Needs review

Status: Needs review Β» Needs work

The last submitted patch, 2: query_string_url-2656010-2.patch, failed testing.

The last submitted patch, 2: query_string_url-2656010-2.patch, failed testing.

borisson_’s picture

Issue tags: -Needs committer feedback

We should disallow it in the facet raw value.

borisson_’s picture

Status: Needs work Β» Needs review
FileSize
639 bytes
2.99 KB

As discussed in yesterday's hangout, this should resolve the issue in a fairly elegant way.

Status: Needs review Β» Needs work

The last submitted patch, 7: query_string_url-2656010-7.patch, failed testing.

The last submitted patch, 7: query_string_url-2656010-7.patch, failed testing.

borisson_’s picture

Status: Needs work Β» Needs review
FileSize
2 KB
3.73 KB

This will still fail. The $value in SearchApiString doesn't have the colon, but the query needs to have the colon. I have no idea how to resolve this.

if (count($active_items)) {
  $filter = $query->createConditionGroup($operator);
  foreach ($active_items as $value) {
    $filter->addCondition($this->facet->getFieldIdentifier(), $value);
  }
  $query->addConditionGroup($filter);
}

Status: Needs review Β» Needs work

The last submitted patch, 10: query_string_url-2656010-10.patch, failed testing.

The last submitted patch, 10: query_string_url-2656010-10.patch, failed testing.

borisson_’s picture

FileSize
3.03 KB
3.38 KB
borisson_’s picture

Status: Needs work Β» Needs review

Run testbot, run.

borisson_’s picture

FileSize
3.38 KB

This needed a reroll, if tests pass I'll commit this as well.

  • borisson_ committed 05498e4 on 8.x-1.x
    Issue #2656010 by borisson_: Query string url processor can't handle a...
borisson_’s picture

Status: Needs review Β» Fixed

Committed.

Status: Fixed Β» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.