API page: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Render%21...

The usage example on the Table form element class refers to a #title element, but unless it's unhandled. The class contains code to handle row-level titles, but it contains nothing at the table level; and specifying a value doesn't seem to do anything. Will follow with a patch to remove it from the usage example.

CommentFileSizeAuthor
#6 table_form_element-2653692-6.patch450 bytesTravisCarden
#2 table_form_element-2653692-2.patch414 bytesTravisCarden
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

TravisCarden created an issue. See original summary.

TravisCarden’s picture

TravisCarden CreditAttribution: TravisCarden at Acquia commented
FileSize
table_form_element-2653692-2.patch414 bytes
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

Perhaps it ought to be changed to #caption?

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Active » Needs work
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

Anyway, agreed #title does not exist.

TravisCarden’s picture

TravisCarden CreditAttribution: TravisCarden as a volunteer commented
Status: Needs work » Needs review
FileSize
table_form_element-2653692-6.patch450 bytes

Oh! Good idea. I didn't even know about #caption.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Reviewed & tested by the community

Looks fine, thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed c3c0980 and pushed to 8.0.x. Thanks!

  • alexpott committed 8eab9ec on 8.1.x 
    Issue #2653692 by TravisCarden: Table form element usage example refers...

  • alexpott committed c3c0980 on 
    Issue #2653692 by TravisCarden: Table form element usage example refers...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.