Support from Acquia helps fund testing for Drupal Acquia logo

Comments

arnaudlumini created an issue. See original summary.

ArnaudDabouis’s picture

ArnaudDabouis’s picture

Added mobile support.

jcisio’s picture

Status: Active » Needs work

Can you explain this patch please? What is e-Transactions and how this module is supposed to work with both?

Also, I've just added responsive support in #2857241: Paybox offsite - responsive mode (RWD). I saw the mobile support but didn't add it because I don't think of any case where you need "mobile only" payment but RWD does not work.

ArnaudDabouis’s picture

E-transactions is a service from french bank Crédit Agricole that uses Paybox as a white label.

Maybe we could offer an option in the backend to switch from one service to another, or create another module that would only overwrite these constants, but it seems a little overkill.

So this patch could be meant to remain a patch for users using this particular service.

jcisio’s picture

Thanks for the explanation. So I'll leave this issue. I think the easiest way is an option to replace Paybox domain with E-transaction domain for all URLs. Do you know any other service that uses white labelled Paybox?

ArnaudDabouis’s picture

No, I don't know any other service using a white labelled Paybox.

jcisio’s picture

Assigned: Unassigned » jcisio
jcisio’s picture

Status: Needs work » Needs review
FileSize
3.68 KB

Here is a proper patch to add E-Transactions support.

jcisio’s picture

Add tests. I'd prefer integration test, but for now it's ok.

  • jcisio committed af6e96b on 7.x-1.x
    Issue #2652852 by ArnaudDabouis, jcisio: Support for Crédit Agricole E-...
jcisio’s picture

Status: Needs review » Fixed
jcisio’s picture

Status: Fixed » Needs review
FileSize
1.04 KB

I should have ran tests locally first.

jcisio’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.