Just noticed something wonky that made me a little cross eyed,
In \Drupal\Core\Field\FieldItemListInterface there is a systematic mistake.....
There are many @see tags on methods that are not references to other information they are just useless references to them same method!
Take the magic method \Drupal\Core\Field\FieldItemInterface::__set()
/**
* Magic method: Sets a property value of the first field item.
*
* @see \Drupal\Core\Field\FieldItemInterface::__set()
*/
public function __set($property_name, $value);
If anyone can point me at the more complete documentation I would be grateful ... otherwise I think these circular @see tags should be deleted.
Comment | File | Size | Author |
---|---|---|---|
#5 | 2650212-5.patch | 1.28 KB | felribeiro |
Comments
Comment #2
dawehnerHa, I would imagine that __set() should refer to __get() and __isset() to __unset(). Happy that you managed get out of the infinite loop.
Comment #3
jhodgdonThanks! Yes we should fix those.
Comment #4
felribeiro CreditAttribution: felribeiro at CI&T commentedComment #5
felribeiro CreditAttribution: felribeiro at CI&T commentedComment #6
jhodgdonLooks good to me, thanks!
Comment #7
alexpottCommitted 8a13b8a and pushed to 8.0.x. Thanks!