Filter search results for current language

I think it makes sense to do this by default. we should probably add an integration test for this behavior as well though.

I don't see any test that confirms the behavior for multilingual at all so if you feel this should be handled in another issue that would make sense.

Anyway, the code change looks great.

Please note that the "Item language" field can now have any machine name, it doesn't have to be search_api_language. Therefore, this code might now throw an exception one some sites (and more later, once it becomes possible to change the field ID through the UI).

In any case, generally I agree with this issue, though I feel it should be configurable. But the final decision is swentel's anyways.

Although this does filter for the langcode, the resulting entities do not display the translation, so entities will link to the default language. A small change of $entity = \Drupal::service('entity.repository')->getTranslationFromContext($entity, $langcode); fixes this.

Updating the patch with the suggested change above. This allows the content listing to show the links to the translations and uses the right language entity if that display is chosen.

Yeah, some tests here would be nice.
Tests are now finally working also :)

Hi, i am new to drupal...i wanted to limit my search result by the current language of my website. I have 'French' & 'English' language on my website. How do i go around to apply this patch?In what file do i add these line of codes?

Thanks

Hi, i am new to drupal...i wanted to limit my search result by the current language of my website. I have 'French' & 'English' language on my website. How do i go around to apply this patch?In what file do i add these line of codes?

First off: Are you actually using this module ("Search pages" on your "Extend" page), and not looking for information about the "Search" module included in Drupal itself?

If you're using this module, you should apply the patch from within the search_api_page folder, which also contains search_api_page.module, using patch -p1. It will modify the src/Controller/SearchApiPageController.php file (relative to that folder).

edit: added org

I don't know why #11 was needed, in any case - we still need those tests. We should wait to write those tests until #2709953: Support the search api display plugin is committed, because that refactors them from simpletest to phpunit-based browser tests.

Patch #7 did not worked, but #11 worked for me on :

• Drupal 8.3.7
• Search API 8.x-1.4
• Search API Pages 8.x-1.0-alpha11

Just tested #11 which works as expected.
Setting RTBC since we seem to have no time for tests ;-)

This is an attempt at a test, but it doesn't pass. I don't know if the problem is with the fix or with the test. But I'm assuming the problem is with the test.

</code><ol>

<li>
<code>
+++ b/src/Controller/SearchApiPageController.php
@@ -74,6 +74,10 @@ class SearchApiPageController extends ControllerBase {
+      // Add filter for current language.
+      $langcode = \Drupal::service('language_manager')->getCurrentLanguage()->getId();
+      $query->addCondition('search_api_language', $langcode);

Not 100% sure, but doesn't the content language make more sense here than the interface language?
Also, it might make sense to only do that if there's more than one language available? Otherwise we waste performance on single-language sites. (In D7 we even had that filter configurable, but I guess that's "just use Views already!" territory of feature creep.)

+++ b/src/Controller/SearchApiPageController.php
@@ -95,6 +99,9 @@ class SearchApiPageController extends ControllerBase {
+        // Get the translated entity.
+        $entity = \Drupal::service('entity.repository')->getTranslationFromContext($entity, $langcode);
+

+++ b/tests/src/Functional/LanguageIntegration.php
@@ -0,0 +1,84 @@
+class LanguageIntegration extends FunctionalTestBase {

+++ b/tests/src/Functional/LanguageIntegration.php
@@ -0,0 +1,84 @@
+    $bird_node->addTranslation('nl', ['title' => 'bird: Havik']);
+    $bird_node->addTranslation('es', ['title' => 'bird: Halcon']);

Thank you very much helping write that test @drunken monkey! I think we can commit this as soon as someone comes back with positive manual test-results.

Since @StryKaizer set this to rtbc earlier, I guess we can commit this even without an explicit +1 on #17.

Committed and pushed. Thanks everyone!