Hi,

I've heard excellent things about your module, but I haven't found any answer yet to its compatibility with Organic Groups. Currently, members of an OG are notified when someone submits a comment to a post. Would activating this module mean they were notified twice if they had commented on the same post?

Cheers,

James

CommentFileSizeAuthor
#5 264584_comment_notify_limit_node_types.patch2.04 KBgreggles
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Status: Active » Fixed

IF they are in the same group and IF they select the comment_notify checkbox then yes, they would get double notifications.

I don't think it's a good idea to use these two together, or if you do you should default this one to "off" for authenticated users to prevent duplicate mailings by default.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

halfiranian’s picture

halfiranian CreditAttribution: halfiranian commented
Status: Closed (fixed) » Active

Thanks for that. As a possible future feature suggestion, could one enable 'comment notify' for only some types of nodes?

My OG nodes are not the same as my non-OG nodes. That would sort my problem!

Hope it's not a cheeky suggestion. Fully understand if you're too busy/have other things to focus on.

Cheers,

J

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Title: Compatibility with Organic Groups? » Limit Comment Notify to Certain Node Types
Version: 5.x-1.6 » 5.x-1.x-dev
Category: support » feature

That seems reasonable to me.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Assigned: Unassigned » greggles
Status: Active » Needs review
FileSize
264584_comment_notify_limit_node_types.patch2.04 KB

And here's a patch which does this. Can you help test it?

Thanks!

halfiranian’s picture

halfiranian CreditAttribution: halfiranian commented

Thank you!

Sure, I'll try and test it today or tomorrow.

Cheers again!

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Version: 5.x-1.x-dev » 5.x-2.x-dev
Status: Needs review » Fixed

This is now added to the 5.x-2.x branch http://drupal.org/cvs?commit=130458 but it will take a few hours for that to get "re-rolled."

Let me know if you have any troubles with it.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.