Follow-up to #2490966: [Meta] Replace deprecated usage of entity_create with a direct call to the entity type class

Problem/Motivation

According to #2346261: Deprecate entity_create() in favor of a <EntityType>::create($values) or \Drupal::entityManager()->getStorage($entity_type)->create($values), entity_create() function is going to be deprecated so we shouldn't use it anymore. When the entity type is known we should directly call <EntityType>::create(). What to do when the entity type is not known or is variable is upon discussions.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task
Issue priority Normal because it's just about code cleanup and good practices
Prioritized changes The main goal of this issue is DX, performance and removing code already deprecated for 8.0.0. (Direct calls to EntityType::create are better than generic calls to entity_create for readability)
Disruption This change is not disruptive at all as it only replaces deprecated functions call by their exact equivalent.

Proposed resolution

Replace the deprecated call to entity_create() by a proper call to <EntityType>::create().

Before:

entity_create('field_config', $field_values)->save();

After:

use Drupal\field\Entity\FieldConfig;
FieldConfig::create($field_values)->save();

Remaining tasks

Contributor tasks needed
Task Novice task? Contributor instructions Complete?
Create a patch Instructions Done
Manually test the patch Novice Instructions
Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards Instructions

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
#10 interdiff-2641626-4-9.txt819 bytesheykarthikwithu
#10 2641626-9.patch4.29 KBheykarthikwithu
#4 view-2641626-4.patch4.02 KBMac_Weber
#2 view-2641626-2.patch4.28 KBMac_Weber
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Mac_Weber created an issue. See original summary.

Mac_Weber’s picture

Mac_Weber CreditAttribution: Mac_Weber as a volunteer commented
FileSize
view-2641626-2.patch4.28 KB

Status: Needs review » Needs work

The last submitted patch, 2: view-2641626-2.patch, failed testing.

Mac_Weber’s picture

Mac_Weber CreditAttribution: Mac_Weber as a volunteer commented
FileSize
view-2641626-4.patch4.02 KB

Fixed class aliasing

Mac_Weber’s picture

Mac_Weber CreditAttribution: Mac_Weber as a volunteer commented
Status: Needs work » Closed (fixed)
Mac_Weber’s picture

Mac_Weber CreditAttribution: Mac_Weber as a volunteer commented
Status: Closed (fixed) » Needs review
Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Status: Needs review » Needs work

Soooo close...

Patch applies, and gets all but one of the occurrences of entity_load('view'). It's in DisplayTest.php.

Rerunning the test anyway because that could be informative.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented
Assigned: Unassigned » heykarthikwithu

working on this.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia commented
Assigned: heykarthikwithu » Unassigned

The issue title states this issue scopes only for the replacement of entity_create replacement.

Patch applies, and gets all but one of the occurrences of entity_load('view'). It's in DisplayTest.php.

Does this needs a new followup/existing issue already exist OR we need to push into this one ?

P.S. : #8 automatically got unassigned when submitting form. feel free to assign again but I have question on the scope of this issue

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented
Status: Needs work » Needs review
FileSize
2641626-9.patch4.29 KB
interdiff-2641626-4-9.txt819 bytes

Changes as per #7.

Patch applies, and gets all but one of the occurrences of entity_load('view'). It's in DisplayTest.php.

@naveenvalecha, I have checked DisplayTest.php, their was an entity_create,

$view = entity_create('view')->getExecutable();

so i proceeded to give a patch, this might be a copy paste mistake by Mile23.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia commented
Status: Needs review » Reviewed & tested by the community

so i proceeded to give a patch, this might be a copy paste mistake by Mile23.

#10, well make sense.
Here we go, applied patch locally and there was no entity_create left, Thanks!

  • catch committed 8d7c0ff on 8.1.x 
    Issue #2641626 by Mac_Weber, heykarthikwithu, naveenvalecha: Replace...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Tag1 Consulting commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.1.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.