Follow-up to #2490966: [Meta] Replace deprecated usage of entity_create with a direct call to the entity type class
Problem/Motivation
According to #2346261: Deprecate entity_create() in favor of a <EntityType>::create($values) or \Drupal::entityManager()->getStorage($entity_type)->create($values), entity_create() function is going to be deprecated so we shouldn't use it anymore. When the entity type is known we should directly call <EntityType>::create()
. What to do when the entity type is not known or is variable is upon discussions.
Beta phase evaluation
Issue category | Task |
---|---|
Issue priority | Normal because it's just about code cleanup and good practices |
Prioritized changes | The main goal of this issue is DX, performance and removing code already deprecated for 8.0.0. (Direct calls to EntityType::create are better than generic calls to entity_create for readability) |
Disruption | This change is not disruptive at all as it only replaces deprecated functions call by their exact equivalent. |
Proposed resolution
Replace the deprecated call to entity_create()
by a proper call to <EntityType>::create()
.
Before:
entity_create('field_config', $field_values)->save();
After:
use Drupal\field\Entity\FieldConfig;
FieldConfig::create($field_values)->save();
Remaining tasks
Task | Novice task? | Contributor instructions | Complete? |
---|---|---|---|
Create a patch | Instructions | Done | |
Manually test the patch | Novice | Instructions | |
Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards | Instructions |
User interface changes
None.
API changes
None.
Comment | File | Size | Author |
---|---|---|---|
#4 | responsive_image_style-2641610-4.patch | 2.55 KB | Mac_Weber |
Comments
Comment #2
Mac_Weber CreditAttribution: Mac_Weber as a volunteer commentedComment #4
Mac_Weber CreditAttribution: Mac_Weber as a volunteer commentedFixed missing class aliasing
Comment #5
Chi CreditAttribution: Chi commentedLooks good.
Comment #6
catchShouldn't this be listed alphabetically?
Comment #7
Mac_Weber CreditAttribution: Mac_Weber as a volunteer commented@catch I had this discussion with at #2641522: Replace deprecated usage of entity_create('date_format') with a direct call to DateFormat::create() and on IRC. We asked other people which are more documentation aware but we are still waiting for an answer. We could not find any coding standard documentation regarding the
use
statement being listed alphabetically. Yet most developers, including me, prefer to keep it alphabetically =)Please post a link if you find such documentation because I had myself a patch people said we should not care about it and chose to keep the issue with the statements unsorted.
Comment #8
catchOK apparently there is no standard per #1624564: Coding standards for "use" statements.
Comment #10
catchCommitted/pushed to 8.1.x, thanks!