Follow-up to #2490966: [Meta] Replace deprecated usage of entity_create with a direct call to the entity type class

Problem/Motivation

According to #2346261: Deprecate entity_create() in favor of a <EntityType>::create($values) or \Drupal::entityManager()->getStorage($entity_type)->create($values), entity_create() function is going to be deprecated so we shouldn't use it anymore. When the entity type is known we should directly call <EntityType>::create(). What to do when the entity type is not known or is variable is upon discussions.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task
Issue priority Normal because it's just about code cleanup and good practices
Prioritized changes The main goal of this issue is DX, performance and removing code already deprecated for 8.0.0. (Direct calls to EntityType::create are better than generic calls to entity_create for readability)
Disruption This change is not disruptive at all as it only replaces deprecated functions call by their exact equivalent.

Proposed resolution

Replace the deprecated call to entity_create() by a proper call to <EntityType>::create().

Before:

entity_create('field_config', $field_values)->save();

After:

use Drupal\field\Entity\FieldConfig;
FieldConfig::create($field_values)->save();

Remaining tasks

Contributor tasks needed
Task Novice task? Contributor instructions Complete?
Create a patch Instructions Done
Manually test the patch Novice Instructions
Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards Instructions

User interface changes

None.

API changes

None.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Mac_Weber created an issue. See original summary.

Mac_Weber’s picture

Status: Needs review » Needs work

The last submitted patch, 2: responsive_image_style-2641610-2.patch, failed testing.

Mac_Weber’s picture

Status: Needs work » Needs review
FileSize
2.55 KB

Fixed missing class aliasing

Chi’s picture

Status: Needs review » Reviewed & tested by the community

Looks good.

catch’s picture

Status: Reviewed & tested by the community » Needs review
+++ b/core/modules/responsive_image/src/Tests/ResponsiveImageFieldDisplayTest.php
@@ -13,6 +13,7 @@
+use Drupal\responsive_image\Entity\ResponsiveImageStyle;

Shouldn't this be listed alphabetically?

Mac_Weber’s picture

@catch I had this discussion with at #2641522: Replace deprecated usage of entity_create('date_format') with a direct call to DateFormat::create() and on IRC. We asked other people which are more documentation aware but we are still waiting for an answer. We could not find any coding standard documentation regarding the use statement being listed alphabetically. Yet most developers, including me, prefer to keep it alphabetically =)

Please post a link if you find such documentation because I had myself a patch people said we should not care about it and chose to keep the issue with the statements unsorted.

catch’s picture

Status: Needs review » Reviewed & tested by the community

OK apparently there is no standard per #1624564: Coding standards for "use" statements.

  • catch committed 4db570e on 8.1.x
    Issue #2641610 by Mac_Weber: Replace deprecated usage of  entity_create...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.1.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.