For me -konqueror user- the floats on the "admin groups" of the node edit forms was always annoying. The textfields were inaccessible.
But witth the collapsible parts they becme even moer annyoing: They now jump around on teh page when collapsed or folded out.
This patch simply removes all the floats frolm these groups.
I beleive theis looks and feels much better. It appears more stable on your page. It feels more like one expects: only a single row of collapses, instead of some odd row with columns.
And last but not least: that part was amoungst the hardests to theme. I think this is a good moment to get rid of them.
Oh, and it removes quite some code/cruft from drupal.css :)
Comment | File | Size | Author |
---|---|---|---|
#7 | uglyfloats.png | 53.75 KB | Bèr Kessels |
#2 | collapsible_floats_new_7.png | 13.07 KB | Bèr Kessels |
#1 | collapsible_floats3.png | 178.97 KB | Bèr Kessels |
non_floating_node_admin.patch | 835 bytes | Bèr Kessels | |
Comments
Comment #1
Bèr Kessels CreditAttribution: Bèr Kessels commentedhere is an example of the jumping fieldsets: A complete set of screenshots can be found on my computer: http://webschuur.dyndns.org/DMP/collapsible/
Comment #2
Bèr Kessels CreditAttribution: Bèr Kessels commentedand here is how it looks with the patch.
Comment #3
Thox CreditAttribution: Thox commentedThis seems a fair temporary fix for Konqueror, although it will affect all browsers. In the long term we need to improve the layout of the form itself.
Comment #4
Bèr Kessels CreditAttribution: Bèr Kessels commentedAllthoughI presented it as a fix for myself and konqueror. I meant it as a fix in general. IMO the floated collapsed forms look and feel strange, on konqueror particularly, bu in firefox too. Having them underneath eachother is much nicer and friendlier. Worpress has that too: one collapse per line.
Comment #5
Bèr Kessels CreditAttribution: Bèr Kessels commentedThis pathc still applies.
IMO we *really* do not ned floating elements with the current new collapsing form elements. So can someone please comment on this patch? If you think you really need the floating form elements, please tell why. And if you dont think you need it, please try and comment on this patch.
Comment #6
moshe weitzman CreditAttribution: moshe weitzman commentedI like the compactness of the current approach ... If you feel that themers will not know how to override this, then please add some comments to drupal.css or elswhere.
Comment #7
Bèr Kessels CreditAttribution: Bèr Kessels commentedthe curertn floats have not other reason to be there, then leftovers from teh pre-collapsible-era.
If we cannot do bettert then it is now, then at least removing the floats makes it all behave better.
See the att. screenshot: the comment options are "lost", they are hard to be found by a pesron scanning the UI.. The top-element does not fill out the full width (just looks ugly and inconsistent) and collapsing/uncollapsing makes this all behave even stranger.
Comment #8
moshe weitzman CreditAttribution: moshe weitzman commentednot sure why your 'author' group is so wide. what browser are you using. try to reproduce in a different browser.
mine is compact and thus all the 3 groups fit nicely in 1 row.
maybe this patch is a good idea. i can't decide.
Comment #9
Bèr Kessels CreditAttribution: Bèr Kessels commentedI use konqueror. Inded it does not behave this strange for FF/moz, nor for IE6. But I remember that IE pre 6 had troubles with the floats too, Not sure how they do now, with the collapses.
Comment #10
Dries CreditAttribution: Dries commentedThis is about CVS, not 4.6.
Comment #11
chx CreditAttribution: chx commentedIndeed it is about CVS, and should get in.
It is so very strange that we have three collapses in one row. Unless you are used to the old, non-collapsed node edit form, you'll feel this very strange. "I click on this, in the middle of nothing I can see a wad of options... what??"
One collapse per row is better.
Comment #12
Dries CreditAttribution: Dries commentedShouldn't we clean up the generated HTML a bit too? If the node edit form becomes a 'standard form', we don't have to generate a bunch of CSS-tags. (This is also something the form API will take care of in future so it doesn't hurt to remove the extra tags for now.)
Comment #13
Bèr Kessels CreditAttribution: Bèr Kessels commentedThe patch still applies.
An Dries: No. I think it is not a good idea to remove the CSS classes.
The fact that we offer a decent default does not mean others (Read Chris ;) ) will not make nicer looking and better forms *for certain uses*. I, for example have one site where I style my forum editing pages different from the node/add etc.
I beleive that, untill we have that node wrapper in core, we should certainly not remove classes and IDs.
Comment #14
moshe weitzman CreditAttribution: moshe weitzman commentedi withdraw my earlier hesitancy about this patch. is a good idea.
Comment #15
Dries CreditAttribution: Dries commentedCommitted to HEAD. Thanks.
Comment #16
(not verified) CreditAttribution: commentedComment #17
(not verified) CreditAttribution: commentedComment #18
(not verified) CreditAttribution: commented