Fatal Error When Trying to Manage the Display of a Field with a GeSHi Filter [#2629930]

Fatal error: Declaration of Drupal\geshifield\Plugin\Field\FieldFormatter\GeshiFieldDefaultFormatter::viewElements() must be compatible with Drupal\Core\Field\FormatterInterface::viewElements(Drupal\Core\Field\FieldItemListInterface $items, $langcode) in /opt/lampp/htdocs/drupal-8-agnostic/modules/geshifilter/geshifield/src/Plugin/Field/FieldFormatter/GeshiFieldDefaultFormatter.php on line 24

It looks like like $langcode needs to be added to viewElements() in GeshiFieldDefaultFormatter to properly extend FormatterBase's viewElements().

I am using Drupal 8.0.1

Comment	File	Size	Author
#2	added_langcode_to_viewElements-2629930-1.patch	696 bytes	meaton
#2	8.x-1.x: PHP 5.5 & MySQL 5.5 CI error

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

6 December 2015 at 22:24

meaton created an issue. See original summary.

Comment #2

meaton CreditAttribution: meaton commented 6 December 2015 at 22:26

Status:

Active

» Needs review

File	Size
added_langcode_to_viewElements-2629930-1.patch	696 bytes
8.x-1.x: PHP 5.5 & MySQL 5.5 CI error

Comment #3

meaton CreditAttribution: meaton commented 6 December 2015 at 22:27

Title:

Fatal Error When Trying to Managed the Display of a Field

» Fatal Error When Trying to Manage the Display of a Field with a GeSHi Filter

Comment #4

17 December 2015 at 13:34

yukare committed 9007f19 on 8.x-1.x authored by meaton

Issue #2629930 by meaton: Fatal Error When Trying to Manage the Display...

Comment #5

yukare CreditAttribution: yukare commented 17 December 2015 at 13:36

Status:

Needs review

» Fixed

I commited your patch, thanks. Geshifield need tests and maybe more work. Please use and test it and report any issue you find, i will do a release soon and would be good find any issue before this.

Comment #6

meaton CreditAttribution: meaton commented 17 December 2015 at 16:57

Will do! I am using Geshi Filter for a project I am working on and have had some issue, but the issues seem to revolve around using the module in a Pantheon environment. I will try and prove this out and post anything that I uncover. Thanks!