Problem/Motivation

\Drupal\embed\Form\EmbedButtonForm gets the entity manager injected. But shortly before 8.0.0, that service was deprecated and split up into many more smaller services (the EntityManager service was enormous/unusable). See https://www.drupal.org/node/2549139.

Proposed resolution

Inject only the necessary services split off from EntityManager, rather than this enormous service.

Remaining tasks

Do it.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#8 embed-replace_entity_manager-2625764-8.patch3.1 KBoenie
#3 embed-replace_entity_manager-2625764-3.patch2.71 KBoenie
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers created an issue. See original summary.

slashrsm’s picture

slashrsm CreditAttribution: slashrsm as a volunteer commented
Issue tags: +Media Initiative, +D8Media
oenie’s picture

oenie CreditAttribution: oenie as a volunteer commented
Status: Active » Needs review
FileSize
embed-replace_entity_manager-2625764-3.patch2.71 KB

Replaced the EntityManager by the EntityTypeManager (only usage seemed to be getStorage())

Status: Needs review » Needs work

The last submitted patch, 3: embed-replace_entity_manager-2625764-3.patch, failed testing.

The last submitted patch, 3: embed-replace_entity_manager-2625764-3.patch, failed testing.

The last submitted patch, 3: embed-replace_entity_manager-2625764-3.patch, failed testing.

The last submitted patch, 3: embed-replace_entity_manager-2625764-3.patch, failed testing.

oenie’s picture

oenie CreditAttribution: oenie as a volunteer commented
FileSize
embed-replace_entity_manager-2625764-8.patch3.1 KB

This should fare a bit better ...

oenie’s picture

oenie CreditAttribution: oenie as a volunteer commented
Status: Needs work » Needs review
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers as a volunteer commented
Status: Needs review » Reviewed & tested by the community 
+++ b/src/Form/EmbedButtonForm.php
@@ -48,7 +48,7 @@ class EmbedButtonForm extends EntityForm {
    *   The entity manager service.

Not yet updated.

Can be fixed on commit.

slashrsm’s picture

slashrsm CreditAttribution: slashrsm at Examiner.com commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks!

  • slashrsm committed 5093cb4 on 8.x-1.x authored by oenie 
    Issue #2625764 by oenie, Wim Leers, slashrsm: Stop using/injecting the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.