Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The migrate module is still considered an experimental module. As a result, its code and tests have been reviewed less than other more mature code. Attach are changes noted during a review of the files in core/modules/migrate/src/Tests/*.php. These changes include adding docblocks, missing @param/@var/@return descriptions and a few coding style changes.
Comment | File | Size | Author |
---|---|---|---|
#9 | 2624914-9-migrate-module-src-test-d8.patch | 17.57 KB | Lars Toomre |
Comments
Comment #2
Lars Toomre CreditAttribution: Lars Toomre as a volunteer commentedAttached is a patch that includes corrections for eleven files in migrate/src/Tests directory.
Comment #3
Lars Toomre CreditAttribution: Lars Toomre as a volunteer commentedFor file migrate/src/Tests/MigrateEmbeddedDataTest.php, the sniff Drupal.Classes.UnusedUseStatement.UnusedUse reports a false positive error for an unused use statement. Created Coder issue #2624934: False sniff for Drupal.Classes.UnusedUseStatement.UnusedUse to resolve this for automatic Coder review.
Comment #4
Lars Toomre CreditAttribution: Lars Toomre as a volunteer commentedThe file migrate/src/Tests/MigrateTestBase.php reports four false positive sniffs for a code line with a short, in-line anonymous function. Created Coder issue #2624936: False sniffs with short in-line anonymous functions to address this issue in the future.
Comment #5
Lars Toomre CreditAttribution: Lars Toomre as a volunteer commentedFiled a third Coder issue #2624578: Correct blank line spacing in DocComment.TagGroupSpacing to resolve the successive @group and @coversDefaultClass directives without a blank line in between. That results in a false positive sniff Drupal.Commenting.DocComment.TagGroupSpacing for the file migrate/src/Tests/MigrationTest.php.
With the application of the patch in issue and resolution of the three Coder issues, all of the files in migrate/src/Tests/*.php should pass the Coder review.
Comment #6
benjy CreditAttribution: benjy at PreviousNext commentedMigrate updates look good.
Comment #9
Lars Toomre CreditAttribution: Lars Toomre as a volunteer commentedI am a bit puzzled about why the patch from #2 fails to apply. Here is a re-roll against current core to see if I am missing something.
Comment #10
quietone CreditAttribution: quietone commentedA diff of the two previous two patches shows a probably copy/paste error in /core/modules/migrate/src/Tests/TemplateTest.php
So, since benjy RTBC'ed before this wee mistake, setting back to RTBC.
Comment #11
alexpottCommitted f6b32fd and pushed to 8.0.x and 8.1.x. Thanks!