Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The migrate module is still considered an experimental module. As a result, its code and tests have been reviewed less than other more mature code. Attach are changes noted during a review of the files in core/modules/migrate/src/Plugin/builder/*.php and core/modules/migrate/src/Plugin/destination/*.php. These changes include adding docblocks, missing @param/@var/@return descriptions and a few coding style changes.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 2624888-5-migrate-module-src-plugin-d8.patch | 19.9 KB | Lars Toomre |
Comments
Comment #2
Lars Toomre CreditAttribution: Lars Toomre as a volunteer commentedHere is a patch that covers fourteen files in the migrate/src/Plugin/build and Plugin/destination directories. This issue is related to #2624660: Some fixes to migrate/src/Plugin/*.php files, #2624640: Fixes to docs and code style for migrate/src/*.php files, #2621486: Fixes to migrate/tests/src/Unit/*.php files and #2609590: Correct incorrect use of 'id' string in migration system. In combination they fix up most of the docblock issues in the migrate module and have been created so that they are manageable in size to review and commit.
Comment #3
benjy CreditAttribution: benjy at PreviousNext commentedThanks.
Comment #5
Lars Toomre CreditAttribution: Lars Toomre as a volunteer commentedPatch in #2 no longer applied. Here is a re-roll.
Comment #6
quietone CreditAttribution: quietone commentedReroll looks good, thank you, changes are due to #2609590: Correct incorrect use of 'id' string in migration system being fixed.
So, back to RTBC.
Comment #7
alexpottCommitted 6fc83e4 and pushed to 8.0.x and 8.1.x. Thanks!