ViewResultAssertionTrait::assertIdenticalResultsetHelper verbose output tries to print the arguments for the query that was used, but this always shows up empty.

Before

After patch in #2

CommentFileSizeAuthor
#3 query arguments not empty.png57.57 KBLendude
#2 query_argument_verbose_empty-2616412-2.patch822 bytesLendude
query arguments empty.png47.69 KBLendude
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Lendude created an issue. See original summary.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer commented
Status: Active » Needs review
FileSize
query_argument_verbose_empty-2616412-2.patch822 bytes

And the fix.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer commented
Issue summary: View changes
FileSize
query arguments not empty.png57.57 KB

And an 'after' screenshot.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +rc eligible

Perfect

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: query_argument_verbose_empty-2616412-2.patch, failed testing.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer commented
Status: Needs work » Reviewed & tested by the community

random test fail, back to RTBC

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented

+1 to this.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 81bfce5 and pushed to 8.0.x and 8.1.x. Thanks!

  • alexpott committed 7960cbc on 8.1.x 
    Issue #2616412 by Lendude: ViewResultAssertionTrait verbose Query...

  • alexpott committed 81bfce5 on 8.0.x 
    Issue #2616412 by Lendude: ViewResultAssertionTrait verbose Query...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.