Problem/Motivation

#2605150: UrlItem::generateSampleValue() does not generate a valid uri introduced a random test failure in EntityFile::processStubRow. The function strips the existing scheme from the the file uri. The scheme may be different in many cases. We replace http:// with public://, this adds two additional chars to the url which trigger the database exception.

The random test failure happened in https://www.drupal.org/pift-ci-job/80178

Proposed resolution

Truncate the new url to max length.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 2615450-2.patch1.04 KBwebflo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

webflo created an issue. See original summary.

webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented
Status: Active » Needs review
FileSize
2615450-2.patch1.04 KB
webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented
Issue tags: +Random test failure, +rc eligible
webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented
Issue summary: View changes
webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented
Issue summary: View changes
mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan at Acquia commented
Status: Needs review » Reviewed & tested by the community

Looks good.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 84214e8 and pushed to 8.0.x. Thanks!

  • alexpott committed 84214e8 on 8.0.x 
    Issue #2615450 by webflo: Fix random test failure caused by EntityFile::...

  • alexpott committed 84214e8 on 8.1.x 
    Issue #2615450 by webflo: Fix random test failure caused by EntityFile::...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.