Problem/Motivation

Missing @param doc for the argument Route $route for the method access in class CustomAccessCheck in file core/lib/Drupal/Core/Access/CustomAccessCheck.php

CommentFileSizeAuthor
#13 2614862-13.patch693 bytesrakesh.gectcr
#11 2614862-11.patch1.35 KBrakesh.gectcr
#6 2614862-6.patch693 bytesrakesh.gectcr
#4 2614862-4.patch699 bytesrakesh.gectcr
#2 2614862-1.patch693 bytesrakesh.gectcr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rakesh.gectcr created an issue. See original summary.

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language Malayalam
Location Manchester
CreditAttribution: rakesh.gectcr as a volunteer and at Valuebound commented
Status: Active » Needs review
FileSize
2614862-1.patch693 bytes

Status: Needs review » Needs work

The last submitted patch, 2: 2614862-1.patch, failed testing.

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language Malayalam
Location Manchester
CreditAttribution: rakesh.gectcr as a volunteer and at Valuebound commented
Status: Needs work » Needs review
FileSize
2614862-4.patch699 bytes
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Needs work

Thanks for the issue and patch, and sorry it didn't get reviewed sooner -- I've been on vacation.

This needs a small fix:

+++ b/core/lib/Drupal/Core/Access/CustomAccessCheck.php
@@ -55,6 +55,9 @@ public function __construct(ControllerResolverInterface $controller_resolver, Ac
+   * @param \Symfony\Component\Routing\Route $route
+   *   The route.
+   *
    * @param \Drupal\Core\Routing\RouteMatchInterface $route_match

There should not be a blank line between parameters.

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language Malayalam
Location Manchester
CreditAttribution: rakesh.gectcr as a volunteer and at Valuebound commented
Status: Needs work » Needs review
FileSize
2614862-6.patch693 bytes

Status: Needs review » Needs work

The last submitted patch, 6: 2614862-6.patch, failed testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs work » Reviewed & tested by the community

This looks fine to me. I think the test bot had a glitch. Thanks!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 6: 2614862-6.patch, failed testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

Hm. Same error "corrupt patch". Please upload a new file.

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language Malayalam
Location Manchester
CreditAttribution: rakesh.gectcr as a volunteer and at Valuebound commented
Status: Needs work » Needs review
FileSize
2614862-11.patch1.35 KB
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Needs work

This patch has unrelated stuff in it. :(

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language Malayalam
Location Manchester
CreditAttribution: rakesh.gectcr as a volunteer and at Valuebound commented
Status: Needs work » Needs review
FileSize
2614862-13.patch693 bytes

@jhodgdon
It was a mistake from my side, apologies.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Fixed

Thanks! Looks good now. Committed to both 8.x branches.

  • jhodgdon committed 96f86e6 on 8.0.x 
    Issue #2614862 by rakesh.gectcr: Missing @param doc  for method access

  • jhodgdon committed be3e52b on 
    Issue #2614862 by rakesh.gectcr: Missing @param doc  for method access...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.