https://api.drupal.org/api/drupal/core%21modules%21filter%21tests%21filt...

The documentation for filter_test_filter_format_insert() should state:
Implements hook_ENTITY_TYPE_insert().
not
Implements hook_filter_format_insert().

The same is true of the filter_test_filter_format_update().

CommentFileSizeAuthor
#26 filter-test-correct-hook-doc-2613146-26.patch769 byteszuhair_ak
#23 filter-test-correct-hook-doc-2613146-23.patch769 bytesmsankhala
#16 2613146-16.patch945 bytesrasikap
#3 filter_test_module_fix_hooks_comments-2613146-3.patch737 bytesLOBsTerr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Chi created an issue. See original summary.

LOBsTerr’s picture

LOBsTerr CreditAttribution: LOBsTerr as a volunteer commented
Assigned: Unassigned » LOBsTerr
LOBsTerr’s picture

LOBsTerr CreditAttribution: LOBsTerr as a volunteer commented
FileSize
filter_test_module_fix_hooks_comments-2613146-3.patch737 bytes
LOBsTerr’s picture

LOBsTerr CreditAttribution: LOBsTerr as a volunteer commented
Assigned: LOBsTerr » Unassigned
Status: Active » Needs review
Chi’s picture

Chi CreditAttribution: Chi commented
Title: Cleanup filter_test module. » Cleanup filter_test module
Status: Needs review » Reviewed & tested by the community
cilefen’s picture

cilefen CreditAttribution: cilefen commented
Title: Cleanup filter_test module » Clean up filter_test module
Issue tags: +Documentation
cilefen’s picture

cilefen CreditAttribution: cilefen commented
Title: Clean up filter_test module » filter_test_filter_format_insert() has the wrong "implements" documentation
Chi’s picture

Chi CreditAttribution: Chi commented

There are few other functions with exact same problem. For example block_content_test_block_content_presave(). Shall we create a separate issue for each case?

cilefen’s picture

cilefen CreditAttribution: cilefen commented

@Chi, yes, but do it by module. So, one issue for the block_content module.

LOBsTerr’s picture

LOBsTerr CreditAttribution: LOBsTerr as a volunteer commented

@Chi you can assign the new task to me. Thanks

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: filter_test_module_fix_hooks_comments-2613146-3.patch, failed testing.

LOBsTerr’s picture

LOBsTerr CreditAttribution: LOBsTerr as a volunteer commented
Status: Needs work » Needs review

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

munizjor’s picture

munizjor CreditAttribution: munizjor commented

Changes look good and its 8.1.x test passed.

rasikap’s picture

rasikap CreditAttribution: rasikap at Blisstering Solutions commented
Version: 8.1.x-dev » 8.2.x-dev
Assigned: Unassigned » rasikap
Status: Needs review » Needs work
rasikap’s picture

rasikap CreditAttribution: rasikap at Blisstering Solutions commented
Assigned: rasikap » Unassigned
Status: Needs work » Needs review
FileSize
2613146-16.patch945 bytes

Added patch for 8.2.x

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

msankhala’s picture

msankhala CreditAttribution: msankhala at Srijan | A Material+ Company commented
Status: Needs review » Needs work

The patch #3 does not apply anymore and the patch #16 is making an incorrect change Implements hook_filter_format_disable() => Implements hook_disable(). correct hook is hook_filter_format_disable().

msankhala’s picture

msankhala CreditAttribution: msankhala at Srijan | A Material+ Company commented
Status: Needs work » Needs review
FileSize
filter-test-correct-hook-doc-2613146-23.patch769 bytes

Here is the new patch.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 23: filter-test-correct-hook-doc-2613146-23.patch, failed testing. View results

zuhair_ak’s picture

zuhair_ak
He/Him
Primary language Malayalam
Location Dubai
CreditAttribution: zuhair_ak at Specbee commented
Status: Needs work » Needs review
FileSize
filter-test-correct-hook-doc-2613146-26.patch769 bytes

Seems like a random test failure, have been seeing this in some other issues as well..running testbots again

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 26: filter-test-correct-hook-doc-2613146-26.patch, failed testing. View results

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave as a volunteer commented
Status: Needs work » Reviewed & tested by the community
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed e2432d9 and pushed to 8.7.x. Thanks!

  • catch committed e2432d9 on 8.7.x 
    Issue #2613146 by msankhala, rasikap, zuhair_ak:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.