Problem/Motivation

AFAICT since #1801726: EntityFieldQuery v2, hook_entity_query_alter() has been dead. Discovered in #2557815: Automatically bubble the "user.node_grants:$op" cache context in node_query_node_access_alter().

That leaves only hook_query_TAG_alter(), which is presumably enough.

Proposed resolution

Either:

  1. revive hook_entity_query_alter()
  2. remove its documentation

Given we are almost releasing Drupal 8, I think option 2 is the best option. Plus, nobody seems to have noticed in three years… If the need arises, we could always add back this hook.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#6 2611638-2.patch1.06 KBNikhilesh Gupta
#2 2611638-1.patch1.16 KBWim Leers
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers created an issue. See original summary.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Active » Needs review
FileSize
2611638-1.patch1.16 KB
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and for Drupal Association commented

IMHO we should figure out common usecases for that in contrib and evaluate based upon that, whether its okay to never support it.

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented

This was an annoyance I didnt expect to come across.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Nikhilesh Gupta’s picture

Nikhilesh Gupta CreditAttribution: Nikhilesh Gupta as a volunteer and at Melity commented
Version: 8.1.x-dev » 8.2.x-dev
FileSize
2611638-2.patch1.06 KB

Against the 8.2.x-dev branch

chx’s picture

chx CreditAttribution: chx at Smartsheet commented
Status: Needs review » Reviewed & tested by the community

I added this to D7 to change the execute callback. No need for that now.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Category: Task » Bug report
Priority: Major » Normal
Status: Reviewed & tested by the community » Fixed

Dead documentation is a bug. Committed and pushed 73be8c49eccae54ca8540dbe56b7d8a1dc4c24df to 8.3.x and 8160ba7 to 8.2.x and 0e5dd35 to 8.1.x. Thanks!

  • alexpott committed 73be8c4 on 8.3.x 
    Issue #2611638 by Wim Leers, Nikhilesh Gupta: hook_entity_query_alter()...

  • alexpott committed 8160ba7 on 8.2.x 
    Issue #2611638 by Wim Leers, Nikhilesh Gupta: hook_entity_query_alter()...

  • alexpott committed 0e5dd35 on 8.1.x 
    Issue #2611638 by Wim Leers, Nikhilesh Gupta: hook_entity_query_alter()...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

bradjones1’s picture

bradjones1
Primary language English
CreditAttribution: bradjones1 commented

If anyone misses this hook, see the work ongoing at #2909970: Implement a query-level entity access API (if you needed it for access-related purposes) or a temporary work-around using events at https://github.com/BradJonesLLC/entity_query_alter

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented

#3001496: Add an alter hook to EntityQuery