Problem/Motivation

Now that we have splitted up the entity manager, yeah!, we should expose the entity type manager in more places.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner created an issue. See original summary.

dawehner’s picture

Status: Active » Needs review
FileSize
3.75 KB

There we go

tim.plunkett’s picture

Title: Expose entity type repository on controller base / Entity / Drupal » Expose entity type manager on controller base / Entity / Drupal
Status: Needs review » Reviewed & tested by the community
Issue tags: +rc target triage
xjm’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: -rc target triage +rc target

The added \Drupal method for the entity type manager makes total sense. The one thing that is missing is that the @deprecated should tell people what they should use instead (one of the many services that were added, including but not limited to the entity type manager).

@effulgentsia and I agreed on this being an RC target.

dawehner’s picture

Status: Needs work » Needs review
FileSize
4.02 KB
1.71 KB

There we go, good point.

tim.plunkett’s picture

Status: Needs review » Reviewed & tested by the community

I think that's good enough.

xjm’s picture

Status: Reviewed & tested by the community » Needs review
FileSize
4.36 KB
1.81 KB

I'd suggest this.

tim.plunkett’s picture

Status: Needs review » Reviewed & tested by the community

Even better.

dawehner’s picture

Oh yeah indeed!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 8485135 and pushed to 8.0.x. Thanks!

  • alexpott committed 8485135 on 8.0.x
    Issue #2611086 by dawehner, xjm: Expose entity type manager on...

  • alexpott committed 8485135 on 8.1.x
    Issue #2611086 by dawehner, xjm: Expose entity type manager on...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.