Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
We should re-use the core PluginFormInterface for facet sources instead of defining our own.
Comment | File | Size | Author |
---|---|---|---|
#5 | refactor_facet_source-2610084-5.patch | 10.53 KB | borisson_ |
Comments
Comment #2
borisson_Because the
::buildConfigurationForm
method on theFacetSourceInterface
specifies more arguments than the one onPluginFormInterface
we can't extend that interface.Comment #3
StryKaizerAs discussed today at drupalcamp gent, we should add the facet in the base class in the constructor. For an example, see searchapi, they do the same in their processor base class.
Comment #4
borisson_Very much in favor of this, this makes the interface easier and will make #2648260: Add a "display" plugin type to list all known search pages easier.
Comment #5
borisson_Tests should pass with these changes.
Comment #6
borisson_