in file : core/lib/Drupal/Core/Routing/StackedRouteMatchInterface.php, Wrongly documented the @return

CommentFileSizeAuthor
#2 2608938-1.patch659 bytesrakesh.gectcr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rakesh.gectcr created an issue. See original summary.

rakesh.gectcr’s picture

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Good catch

rakesh.gectcr’s picture

Issue tags: +rc eligible
catch’s picture

Status: Reviewed & tested by the community » Postponed

Thanks for the patch. In order clean up these sorts of coding standards fairly and efficiently, many instances of identical fixes that can be reviewed with git diff --color-words should be combined into a single patch, ideally one that fixes all instances in core in preparation for enabling automated coding standards checking for them. This issue is postponed for now on #2571965: [meta] Fix PHP coding standards in core.

If the standard being fixed already has a coder rule, this issue should me marked as a duplicate of the issue that begins to fix that rule. If there is not yet a coder rule, we should add one. See for example #2606860: Docblock sections out of order in core/lib/Drupal.

Thanks for your ongoing efforts to clean up the codebase and fix these bugs!

  • catch committed 04df0c6 on 8.1.x
    Issue #2608938 by rakesh.gectcr: Wrong @return comment block in...

  • catch committed 045327e on
    Issue #2608938 by rakesh.gectcr: Wrong @return comment block in...
catch’s picture

Status: Postponed » Fixed

@xjm pointed out this might not be catchable by coder, so..
Committed/pushed to 8.1.x and cherry-picked to 8.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.