Follow-up to #2590403: Remove "Open in new window" checkbox from EditorLinkDialog — Was: "Consider whitelisting <a>'s target attribute in the Standard install profile"

Problem/Motivation

We forgot to remove all references to the target attribute in core/modules/ckeditor/js/plugins/drupallink/plugin.js

Proposed resolution

Clean up.

Remaining tasks

Patch, Review, Commit

User interface changes

None.

API changes

None.

Data model changes

None.

Why RC target?

As the functionnality has already been removed from Core, leave these references could mislead people that would read our integration to learn how to make their own.

CommentFileSizeAuthor
#2 remove_target_drupallink-2608722-2.patch1.2 KBDuaelFr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DuaelFr created an issue. See original summary.

DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr as a volunteer and at Happyculture commented
Status: Active » Needs review
FileSize
remove_target_drupallink-2608722-2.patch1.2 KB
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Title: Remove forgotten references to target attribute on drupal link plugin » Follow-up for #2590403: Remove forgotten references to the target attribute in the drupallink CKEditor plugin
Component: editor.module » ckeditor.module
Status: Needs review » Reviewed & tested by the community

Patch looks good.

Manually tested.

Note that this is a follow-up for a patch that already was an RC target. But this forgotten bit also doesn't cause any problems; it's just to be consistent with what #2590403 already did.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Issue tags: -rc target triage +rc target

Based on #2590403: Remove "Open in new window" checkbox from EditorLinkDialog — Was: "Consider whitelisting <a>'s target attribute in the Standard install profile" this is dead code, so @effulgentsia and I agreed on this being an RC target. Thanks!

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed ff9845a on 8.0.x 
    Issue #2608722 by DuaelFr: Follow-up for #2590403: Remove forgotten...

  • catch committed ff9845a on 8.1.x 
    Issue #2608722 by DuaelFr: Follow-up for #2590403: Remove forgotten...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.