Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
After #2575703: Remove default fall-through from PlaceholderTrait::placeholderFormat() !placeholders are not considered as valid and tests are failing.
Also because of #2072945: Remove the $langcode parameter in EntityAccessControllerInterface::access() and friends we have to update some functions.
And there are some tests that are failing, you can see https://qa.drupal.org/pifr/test/1150948
Proposed resolution
Find the !placeholder
usages and replace it with @placeholder
.
See CR https://www.drupal.org/node/2575819
Update functions to recent core changes.
Fix tests, investigate.
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#3 | 2608240-3.patch | 21.97 KB | webflo |
| |||
#2 | fix_tests-2608240-2.patch | 22.9 KB | giancarlosotelo |
|
Comments
Comment #2
giancarlosotelo CreditAttribution: giancarlosotelo at MD Systems GmbH commentedI am replacing all !placeholders, then I remove some empty space in test that leads to a fail and finally I removed
$langcode
fromcheckAccess()
function.And about some warnings like this
Undefined index: title
I am applying a fix in the name.module file.With the patch all tests are green and the head is fixed again.
Comment #3
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedComment #5
webflo CreditAttribution: webflo at UEBERBIT GmbH commented