Problem/Motivation

After #2575703: Remove default fall-through from PlaceholderTrait::placeholderFormat() !placeholders are not considered as valid and tests are failing.

Also because of #2072945: Remove the $langcode parameter in EntityAccessControllerInterface::access() and friends we have to update some functions.

And there are some tests that are failing, you can see https://qa.drupal.org/pifr/test/1150948

Proposed resolution

Find the !placeholder usages and replace it with @placeholder.
See CR https://www.drupal.org/node/2575819

Update functions to recent core changes.

Fix tests, investigate.

Remaining tasks

User interface changes

API changes

Data model changes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

giancarlosotelo created an issue. See original summary.

giancarlosotelo’s picture

Status: Active » Needs review
FileSize
22.9 KB

I am replacing all !placeholders, then I remove some empty space in test that leads to a fail and finally I removed $langcode from checkAccess() function.

And about some warnings like this Undefined index: title I am applying a fix in the name.module file.

With the patch all tests are green and the head is fixed again.

webflo’s picture

FileSize
21.97 KB

  • webflo committed 9a0385c on 8.x-1.x
    Issue #2608240 by giancarlosotelo, webflo: Replace !placeholders
    
webflo’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.