Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The following twig files in aggregator module has missing available variables list - title_attributes, title_prefix, title_suffix, attributes
core/modules/aggregator/templates/aggregator-feed.html.twig
core/modules/aggregator/templates/aggregator-item.html.twig
Comment | File | Size | Author |
---|---|---|---|
#8 | 2607548-8.patch | 5.53 KB | Erno |
#2 | 2607548-2.patch | 1.81 KB | krknth |
Comments
Comment #2
krknth CreditAttribution: krknth as a volunteer and at Valuebound commentedAdded patch
Comment #3
jhodgdonSomeone needs to review this carefully. I am not sure whether:
- these are actually present (I didn't look through the code to figure this out)
- if we normally document them. They look kind of like standard attributes that are present on pretty much every Twig file, so I am not sure we document them in every Twig file?
Hopefully the Twig maintainers will figure this out... moving to theme component since it needs some expert reviewing.
Comment #4
krknth CreditAttribution: krknth as a volunteer and at Valuebound commentedComment #5
joelpittetYes we usually document the variables that we use in the template and they are in the templates.
The work that needs to be done is for this to be added to each template in classy/stable too.
Comment #6
joelpittetAlso they are the magic ones that get added to every template via _template_preprocess_default_variables().
Please ensure the text for the documentation is the same as for those same variables, elsewhere in core.
Comment #7
Erno CreditAttribution: Erno as a volunteer commentedComment #8
Erno CreditAttribution: Erno as a volunteer commentedI added missing variables documentation to these files:
There is still variable 'full' that is not documented. The value is assigned in core\modules\aggregator\aggregator.theme.inc (line 48):
Comment #9
iMiksuCleaning up drupalcampfi tags.
Comment #11
Nikhilesh Gupta CreditAttribution: Nikhilesh Gupta as a volunteer and at Melity commentedComment #12
reedcodes CreditAttribution: reedcodes as a volunteer commentedI reviewed 2607548-8.patch: the title variables have been updated, plus documentation for those variables, in core, classy, and stable template files for the aggregator module.
Comment #14
catchCommitted/pushed to 8.1.x and 8.2.x, thanks!