Problem/Motivation

In order to be compatible with Symfony 3 we need to be compatible with 2.8. Therefore we need to not clone the container. See https://github.com/symfony/symfony/blob/2.8/src/Symfony/Component/Depend...

Proposed resolution

Don't do it. This is rc eligible because it only affects tests.

Remaining tasks

None

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#3 2606470-3.patch645 bytesalexpott
#3 2606470-3.test-only.patch560 bytesalexpott
#2 2606470-2.patch1.18 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Title: Symfony deprecates ContainerBuilder cloning in 2.8 - let's fix this early. » Symfony prevents container cloning in 2.8 - let's fix this early.
Issue summary: View changes
Status: Active » Needs review
FileSize
2606470-2.patch1.18 KB

Let's see what breaks.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
FileSize
2606470-3.test-only.patch560 bytes
2606470-3.patch645 bytes

Great - nothing seems to break. Phew.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Issue summary: View changes

The last submitted patch, 3: 2606470-3.test-only.patch, failed testing.

cilefen’s picture

cilefen CreditAttribution: cilefen commented 
+++ b/core/lib/Drupal/Component/DependencyInjection/Container.php
@@ -626,4 +626,11 @@ public function getServiceIds() {
+   * @inheritDoc

This should be {@inheritdoc}.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Nice!

The last submitted patch, 3: 2606470-3.test-only.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented

Re #6 - that was the test only patch :)

cilefen’s picture

cilefen CreditAttribution: cilefen commented

#9: Oh, that doesn't go in - I see now.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed 533bb68 on 8.0.x 
    Issue #2606470 by alexpott: Symfony prevents container cloning in 2.8 -...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.