Problem/Motivation

As of https://docs.google.com/document/d/1BxgNvyIRcxYGzzA1DLkZ6A4-c8gGFixypNvP... we want to make clear which bits of the URL generation
machinery should be used

Proposed resolution

* \Drupal\Core\Utility\LinkGeneratorInterface::generateFromLink should be marked as internal.
* It should point to \Drupal\Core\Link instead

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 d8_core-2606392-7-d8.patch660 byteser.manojsharma
#4 2606392-4.patch651 bytessdstyles
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner created an issue. See original summary.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented
Parent issue: #2606390: mark \Drupal\Core\Utility\LinkGeneratorInterface::generate as internal » #2491981: There are too many ways to generate URLs and links
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented
Component: base system » documentation
sdstyles’s picture

sdstyles CreditAttribution: sdstyles at FFW commented
Status: Active » Needs review
FileSize
2606392-4.patch651 bytes
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Needs work 
+++ b/core/lib/Drupal/Core/Utility/LinkGeneratorInterface.php
@@ -84,6 +84,9 @@ public function generate($text, Url $url);
+   * @internal Should not be used in user code.
+   *   Use \Drupal\Core\Link instead.

I don't think we put documentation along with the @internal tag? We do that with @deprecated, but I think @api and @internal are stand-alone tags.

er.manojsharma’s picture

er.manojsharma CreditAttribution: er.manojsharma at Publicis Sapient for Publicis Sapient commented
Assigned: Unassigned » er.manojsharma
er.manojsharma’s picture

er.manojsharma CreditAttribution: er.manojsharma at Publicis Sapient for Publicis Sapient commented
Status: Needs work » Needs review
FileSize
d8_core-2606392-7-d8.patch660 bytes

Please check updated patch

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +rc eligible

+1

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed c5255ad on 8.0.x 
    Issue #2606392 by er.manojsharma, sdstyles: mark \Drupal\Core\Utility\...

  • catch committed c5255ad on 8.1.x 
    Issue #2606392 by er.manojsharma, sdstyles: mark \Drupal\Core\Utility\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.