Problem/Motivation

https://www.drupal.org/drupal-8.0 claims we have more than 200 new features and improvements but does not let us know which ones. Of course the changelog http://cgit.drupalcode.org/drupal/tree/core/CHANGELOG.txt would tell us. Uhm, no. It has not been kept up to date in a loooooong time. This is the kind of magic number that will be repeated in the press and blogs, and we'd better have a list to show for it. Anyway, we need to keep our changelog useful if we appear to have an entry for Drupal 8 :)

Proposed resolution

Fill in the missing pieces, fix the wrong elements in the changelog.

Remaining tasks

Reviews, additions, reviews, more additions and reviews :)

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#118 2606334-version-tag.patch334 byteseffulgentsia
#83 interdiff.2606334.77.83.txt1.38 KBYesCT
#83 2606334.83.patch15.81 KBYesCT
#77 interdiff.2606334.73.77.txt1.22 KBYesCT
#77 2606334.77.patch15.63 KBYesCT
#73 interdiff.2606334.72.73.txt710 bytesYesCT
#73 2606334.73.patch15.3 KBYesCT
#72 interdiff.2606334.69.72.txt4.38 KBYesCT
#72 2606334.72.patch15.32 KBYesCT
#69 interdiff.txt2.08 KBGábor Hojtsy
#69 2606334-69.patch14.7 KBGábor Hojtsy
#65 interdiff.txt1.18 KBGábor Hojtsy
#65 2606334-65.patch14.97 KBGábor Hojtsy
#63 interdiff.txt621 bytesGábor Hojtsy
#63 2606334-63.patch14.69 KBGábor Hojtsy
#61 interdiff.txt7 KBGábor Hojtsy
#61 2606334-61.patch14.64 KBGábor Hojtsy
#59 interdiff.txt2.12 KBGábor Hojtsy
#59 2606334-58.patch15.13 KBGábor Hojtsy
#57 interdiff.txt2 KBGábor Hojtsy
#57 2606334-57.patch14.26 KBGábor Hojtsy
#56 interdiff.txt1.26 KBGábor Hojtsy
#56 2606334-56.patch12.63 KBGábor Hojtsy
#55 interdiff.txt1.28 KBGábor Hojtsy
#55 2606334-55.patch12.56 KBGábor Hojtsy
#54 interdiff.txt3.26 KBGábor Hojtsy
#54 2606334-54.patch12.3 KBGábor Hojtsy
#53 2606334-chglog.52.patch11.71 KBlarowlan
#53 interdiff.txt1.62 KBlarowlan
#52 interdiff.txt3.31 KBGábor Hojtsy
#52 2606334-52.patch10.92 KBGábor Hojtsy
#50 2606334-50.patch9.24 KBGábor Hojtsy
#45 interdiff.txt950 bytesGábor Hojtsy
#45 2606334-45.patch11.79 KBGábor Hojtsy
#44 interdiff.txt620 bytesstar-szr
#44 update_changelog_txt-2606334-44.patch11.8 KBstar-szr
#43 interdiff.txt4.58 KBstar-szr
#43 update_changelog_txt-2606334-43.patch11.8 KBstar-szr
#37 interdiff.txt1.28 KBdawehner
#37 2606334-36.patch11.82 KBdawehner
#35 2606334.patch11.5 KBcatch
#35 interdiff.txt5.78 KBcatch
#34 interdiff.txt3.82 KBWim Leers
#34 changelog-2606334-34.patch10.8 KBWim Leers
#33 interdiff.txt3.17 KBWim Leers
#33 changelog-2606334-33.patch9.54 KBWim Leers
#31 interdiff.txt545 bytesnevergone
#31 2606334-changelog.31.patch8.4 KBnevergone
#30 2606334-changelog.30.patch8.4 KBlarowlan
#30 interdiff.txt910 byteslarowlan
#14 interdiff-2606334-9to14.txt1.6 KBdavidhernandez
#14 update_changelog_txt-2606334-14.patch8.04 KBdavidhernandez
#9 interdiff.txt845 bytesdawehner
#9 2606334-9.patch7.61 KBdawehner
#8 2606334-8.patch7.26 KBattiks
#7 interdiff.txt4.06 KBGábor Hojtsy
#7 2606334-7.patch7.21 KBGábor Hojtsy
#2 2606334.patch3.79 KBGábor Hojtsy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gábor Hojtsy created an issue. See original summary.

Gábor Hojtsy’s picture

FileSize
3.79 KB
davidhernandez’s picture

What is the qualification for something to be included?

First line has the tpl.php conversions. We could add that all theme functions have been converted, as well. Also, the addition of Classy and Stable.

There are some new modules missing, like the menu link change and the caching ones?

dawehner’s picture

* Added PHPUnit for proper unit testing, see https://phpunit.de/manual/4.8/en/index.html so you can run tests via your IDE
* Added BrowserTestBase as an alternative to simpletest for browser testing (Javascript included in the future)
* Added KernelTestBase to provide a fast API testing of integration of different components

Anonymous’s picture

In addition to noting that translations get downloaded in the installer I think it is important to mention that "the installer is presented in the user's native language according to their browser preference". IMO, this is huge.

Gábor Hojtsy’s picture

@RyanWeal: So the included "Automated import and update of translations in the installer and later." may not be the best wording for that, any better suggestions?

@davidhernandez: I think "higher level" changes are meant to be here. The ones you list seem to be all valid to be included IMHO. I would not list specific API changes. So in that sense, maybe we should remove some of the translation API items :D

Gábor Hojtsy’s picture

Status: Needs work » Needs review
FileSize
7.21 KB
4.06 KB

Thanks for the feedback so far. Here is an update based on those.

1. Grouped frontend changes. This is now listed as the first item for easier reviews. Not sure we want to keep it first. Added some there and moved existing ones there. Need reviews and additions :)
2. Added a testing section as per suggestions from @dawehner.
3. Fixed the items mentioned by @Ryan.

attiks’s picture

Added responsive images

dawehner’s picture

FileSize
7.61 KB
845 bytes

Added a bit more around the symfony components.

star-szr’s picture

+++ b/core/CHANGELOG.txt
-- Added Twig as the default template engine and converted all .tpl.php templates
+    * Added the Stable theme to be used as base theme.

I think we should note that this is the default base theme. "used as the default base theme." maybe.

As for other frontend changes, here are some in no particular order (just numbered for discussion purposes). Not sure the level of detail we want, feel free to reject some of these as too granular:

  1. Removed the template process layer
  2. New, completely overhauled asset library system for CSS and JavaScript
  3. New CSS architecture and standards
  4. Theme suggestions API moved out of preprocess into its own hooks
  5. Consistent use of render arrays rather than the theme() function
  6. New Attribute object that can be manipulated from within templates
  7. show() and hide() in templates removed in favor of a |without Twig filter
  8. Removed most support for versions of Internet Explorer lower than 9

Edited to make one addition.

Gábor Hojtsy’s picture

@Cottser: I think that is fine granularity unless there are a dozen more on that granularity :D If that's it, then I personally think we can include them :)

star-szr’s picture

Missed an important one:

All page variables (title, tabs, etc.) converted to blocks

LewisNyman’s picture

* Modernizr has been added that allows us to make styling changes based on browser support.

davidhernandez’s picture

Added some frontend changes.

Gábor Hojtsy’s picture

So that includes most of Cottser's suggestions, thanks! Did you discuss not including the rest offline or crossposted? :)

davidhernandez’s picture

Nope. I wasn't sure if they really needed to be included, due to the granularity, or how to describe them properly so I left them out. Low hanging fruit I suppose.

YesCT’s picture

I'm not suggesting including all the things, but we might look at these places to get inspired/reminded of things to put in the change log

general things from the front page of https://api.drupal.org/api/drupal/8
closed fixed major and critical feature requests https://www.drupal.org/project/issues/search/drupal?project_issue_follow...

modules removed https://www.drupal.org/node/2116417
modules added https://www.drupal.org/node/2164623

I think change records are a new thing since 8.x started.
The changelog.txt file should mention https://www.drupal.org/list-changes/drupal
and maybe describe a bit of what the difference is there vs the changelog.txt file.

YesCT’s picture

Issue summary: View changes
YesCT’s picture

chx’s picture

- Removed backwards-compatibility with 'magic_quotes_gpc'/'magic_quotes_runtime'
PHP configuration settings. Both are required to be disabled.

Needs to be removed as we require PHP 5.4.0 and that version nuked these two

YesCT’s picture

yeah.

also, I think we can remove
"Drupal 8 can no longer be installed on hosts with the 'magic_quotes_gpc', 'magic_quotes_runtime', or 'safe_mode' PHP ini settings turned on; these settings are deprecated in PHP 5.3 and have no effect anymore in PHP 5.4 and higher."
from
https://www.drupal.org/requirements/php#8
since d8 requires a min php version of 5.5.9 anyway ( https://www.drupal.org/requirements )

Gábor Hojtsy’s picture

OTOH we should say something about "supporting" PHP 7? :)

skyredwang’s picture

I have tested all PHP 7 RC releases so far. I haven't found any problems on D8 yet.

chx’s picture

  • Added support for saving and deleting entities through the controller. - Instead "Full CRUD API for entities." something about complete with a field API and a more fleshed out query API.
  • The revision paragraph is way too long
  • Replaced the core routing system with one built on the Symfony2 framework. - That is incorrect, maybe supplemented or simply use the word "ruined". It was not replaced fully anyways: the only thing keeps it even remotely performant is the same database architecture underneath. Symfony2 could not perform its way out of a wet paper bag.
  • The configuration section says nothing about import and export which is the most important part
  • ClassLoader - PSR-0-compatible autoload routines. - maybe we added this but do we use it? I thought we use the Composer autoloader. The typehint on the classloader in DrupalKernel corroborates such belief.
  • Support added for making HTTP requests through a proxy server. - Nuke this, it was added in 2012, it talks about drupal_http_request which was replaced by Guzzle. Do mention adding Guzzle, however.
  • Mention typed data.
  • Mention config entities and block placement entities most especially. Same block, multiple times, how many people turned to panels for this.
  • Even if it's experimental, migrate mentions a blip.
yoroy’s picture

Some ux changes worth calling out:

Shiny new installer
Redesigned content creation form
Updated and extended Seven admin theme
Responsive admin toolbar

thamas’s picture

Drupal does not load automatically any (vendor) library (eg. jQuery) for better performance.

bojanz’s picture

I'd highlight the fact that we support Composer. It's usually a big deal to external developers.

Once #2608174: Update composer-merge-plugin to latest version lands, we will be able to use Composer not just to download libraries, but also Drupal modules, with no additional tools (other than adding the Drupal Packagist repository). That's a very big workflow improvement/change.

gaele’s picture

+- Dramatically improved the frontend

It's not dramatic. Are you American? :-)

MustangGB’s picture

Should "Phone number" be called "Telephone number"?

larowlan’s picture

Added some stuff I'm proud of contributing to that we'd not covered.

nevergone’s picture

joelpittet’s picture

Suggestions:

  1. HTML Attributes are now self printed objects
  2. Auto-escaping template variables
  3. Branding variables, menus and system messages are now blocks

And yes @MustangGB it should be because that is the name of the module, good idea.

Wim Leers’s picture

  • Improved punctuation/consistency.
  • Added a few clarifications
  • Expanded the "CKEditor added" line into an "improved authoring experience" section with some more high-level bullets, including in-place editing.

EDIT: includes #26.

Wim Leers’s picture

FileSize
10.8 KB
3.82 KB
  • Added a few clarifications/improvements.
  • Added a "Performance" section.
catch’s picture

Crosspost with Wim...

dawehner’s picture

A sandbox for just that could be actually useful.

Expanded the views section a bit.

dawehner’s picture

Status: Needs work » Needs review

Its certainly on needs review ...

star-szr’s picture

Status: Needs review » Needs work

Found some nits and things. Great to see all this in one place :)

As for collaboration maybe something like an etherpad or google doc? ¯\_(ツ)_/¯

  1. +++ b/core/CHANGELOG.txt
    -- Added Twig as the default template engine and converted all .tpl.php templates
    +- Dramatically improved the front end
    

    Nit: This should end in a period or colon or some kind of punctuation.

  2. +++ b/core/CHANGELOG.txt
    -- Replaced the core routing system with one built on the Symfony2 framework.
    +- Refactored routing system based Symfony2 components.
    

    based = based on?

  3. +++ b/core/CHANGELOG.txt
    -- Replaced the core routing system with one built on the Symfony2 framework.
    +- Reworked Menu links / Local actions and tasks based upon the new routing
    

    Why are Menu and Local capitalized here?

  4. +++ b/core/CHANGELOG.txt
    -- Included the HTML5 Shiv library to support HTML5 elements in IE 8 and below.
    +    * Supports configuration schema, dependencies and validation to maintain
    

    Add an oxford comma here before the "and" - "schema, dependencies, and validation"

  5. +++ b/core/CHANGELOG.txt
    -- Included the HTML5 Shiv library to support HTML5 elements in IE 8 and below.
    +      but also blockquotes, code snippets, videos…
    

    I would suggest removing "but also" and replacing it with a comma but maybe that's just me.

  6. +++ b/core/CHANGELOG.txt
    @@ -28,10 +74,14 @@ Drupal 8.0, xxxx-xx-xx (development version)
    +    * Serialization - Allows to serialize complex nested objects into JSON/XML
    ...
    +    * Validator - Allows to ensure that an object is in a valid state based upon
    

    In both cases I think these would read better if "Allows to" was removed.

  7. +++ b/core/CHANGELOG.txt
    -- Support added for making HTTP requests through a proxy server.
    +- Added routing component from Symfony CMF.
    

    Is there duplication here? Routing based on Symfony2 components is mentioned above… just checking.

  8. +++ b/core/CHANGELOG.txt
    -- Added Date field type to core.
    +  * REST api support built in.
    

    s/api/API/

  9. +++ b/core/CHANGELOG.txt
    -- Added Date field type to core.
    +  * Rewritting caching integration for better performance.
    

    s/Rewritting/Rewrote/

    Typo in the first place, but present tense doesn't seem to make much sense here to me.

  10. +++ b/core/CHANGELOG.txt
    -- Added Date field type to core.
    +- Custom blocks are now fieldable, revisionable and translatable entities.
    

    Should have a comma before "and" again, see https://www.drupal.org/drupalorg/style-guide/content.

  11. +++ b/core/CHANGELOG.txt
    -- Added Date field type to core.
    +- An accessible modal API based on improvements made in collaboration with
    +  jQuery UI team and the Views UI.
    

    "the jQuery UI team" I think, and then maybe just "the Views team"? If it's not the Views team I think this sentence could use some rethinking because it sounds like "the Views UI" is a group of people which would be odd :).

  12. +++ b/core/CHANGELOG.txt
    -- Added Date field type to core.
    +  for soliticing feedback from users.
    

    s/soliticing/soliciting/

  13. +++ b/core/CHANGELOG.txt
    -- Added Date field type to core.
    +      testing (Javascript support to be included in the future)
    

    s/Javascript/JavaScript/

Gábor Hojtsy’s picture

@Cottser: IMHO feel free to update the patch :) As for collaboration, I would personally favor committing from this issue multiple times to make incremental changes easier to review. Not sure a google doc would make it clear who changed what/when/why. It also would not end up in issue credits/commit credits without the respective people commenting / posting patch updates in a similar quantity here.

Gábor Hojtsy’s picture

Also there are several comments with valuable insights that I don't think are integrated in the patch. Eg. from chx, bojanz, thamas, yoroy, etc. Does someone want to step up to champion the inclusion of those. We only have 3 days to release now :)

catch’s picture

I'm OK with multiple commits from here, let's address #39 first though then get what we have in?

Then we can keep going for #41 onwards?

star-szr’s picture

Status: Needs work » Needs review
FileSize
11.8 KB
4.58 KB

Multiple commits does sound better. Here's everything from #39 but #39.7, left as is because I'm not sure if it's duplication or not.

I do agree with @joelpittet in #32 that the Attribute thing is worth mentioning, and probably autoescape too. We already have the blocks stuff covered:

* All page template variables converted to blocks.

star-szr’s picture

Oh I missed this, stray bullet point got introduced somewhere.

Gábor Hojtsy’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
11.79 KB
950 bytes

Empty lines are not supposed to be added. Apart of that, looks RTBC for what we have now. We can and will/should iterate on this further once this lands.

catch’s picture

Status: Reviewed & tested by the community » Active

Committed/pushed #45.

Back to 'active' for more updates.

  • catch committed 645e7f9 on 8.0.x
    Issue #2606334 by Gábor Hojtsy, Cottser, dawehner, Wim Leers,...
MustangGB’s picture

Feel free to include #29.

dawehner’s picture

+1 for the approach to improve things over time!

Gábor Hojtsy’s picture

Status: Active » Needs review
FileSize
9.24 KB

re #17: - added a note at the top, reviewed the list of removed modules, they are all here; did not yet ensure all the added modules are represented
re #24: - addressed all points (some were already), except PSR-0, we don't claim we use those components :D
re #25: - all done, great stuff :)
re #26: - already done
re #27: - added a short not on Composer, improvements welcome
re #28: - changed it to "Significantly" ;)
re #29: - changed it to "Telephone"
re #32: - added the auto-escaping one, I think the HTML attribtues may be a detail(?), the blocks are already there :)

Finally indented things consistently and used consistent second level list item markers (* instead of -). And where I needed to change/add things I also reworded with an active verb to start with in the usual form of the changelog elsewhere :)

I think this catches up with all suggestions so far with the notable exception of not all added modules mentioned :)

joelpittet’s picture

Nice consolidation @Gábor Hojtsy. Likely big enough for an commit iteration, though I'll give it more than 15 min;)

Gábor Hojtsy’s picture

Ran through the new modules and added the following:

- automated cron
- ban
- breakpoint
- custom menu links
- text editor

Also reworded the editor items a bit while I was there to active verb changelog format. And added a "Made media management (a little) easier" (we need to be honest there I think, its small changes). There are probably other small goodies lying unmentioned still :) Any good ideas?

larowlan’s picture

added security section based on chat in #drupal-security and using https://dev.acquia.com/blog/drupal-8/10-ways-drupal-8-will-be-more-secur... for some inspiration

Gábor Hojtsy’s picture

1. Re @larowlan: Remove now double mention of PHP filter and autoescape in twig :) When did core support import config through PHP? I am not sure that was a core feature?

2. I remembered Dries had a list of features in a keynote and that was worth checking against :) Indeed. Several good ones that we forgot earlier: responsive tables (also in views), schema.org output, semantic HTML 5 tags, retina compatible icons, searchable and better readable module list, drag and drop file uploads, simple VBO :) BTW video at https://www.youtube.com/watch?v=8uhNFoOnz_g

Gábor Hojtsy’s picture

Also @larowlan you made me think of custom comment types too :) So comments got their own section. And I integrated the image filter into the media portion now.

Gábor Hojtsy’s picture

Fixed the mention of the PHP filter for blocks and adding configurable view modes, which is also new to D8 :)

Gábor Hojtsy’s picture

Sacrifice some too low level items from the language section, only keep the bigger ones. Did miss the possibility of language fallback in interface translation, added that.

Stopping for tonight :)

catch’s picture

Is it worth mentioning that a lot of declarative information (libraries, permissions, routes etc.) has been moved from PHP to YAML?

Statistics module view counting works with the page cache and reverse proxies now.

Gábor Hojtsy’s picture

Sorry could not resist mentioning actual previews and semantic versioning. Also updated some key points with examples while I was at it. All inspired by the D8 slideshow (which honestly will need to get updated with some of this info we collect here :D) Aaaand really stopping for tonight :D

David_Rothstein’s picture

Status: Needs review » Needs work
  1.  Drupal 8.0.x, xxxx-xx-xx (development version)
     ----------------------
    

    Can we add two extra "-" here so it's even with the line above? :) (We actually just fixed that throughout CHANGELOG.txt not too long ago.)

  2.  Drupal 8.0.x, xxxx-xx-xx (development version)
     ----------------------
    +
    +The following is a list of the most important changes made to Drupal in 8.0.0.
    +For a detailed list of changes with background information, see
    +https://www.drupal.org/list-changes/drupal
    

    This is out of place here. If it belongs in CHANGELOG.txt, it should be in an intro section at the top of the file or something like that (not in the Drupal 8.0.0 section). It seems like a good idea though.

  3. +    * Removed the Overlay module from core but kept the functionality with a
    +      simple but dynamic "Back to site" link.
    

    This is confusing... I think maybe it's trying to say: 'Removed the Overlay module from core and replaced it with a simple, dynamic "Back to site" link.'

  4. +    * Redesigned icons to look good on high resolution (retina) displays too.
    

    Remove "too".

  5. +    * Completed the field API and improved the Entity Query API.
    

    I am not sure what it means to "complete the field API" but it sounds inaccurate by definition :) Maybe just "Improved the field API and entity query API"? (Or make them separate bullet points.)

  6. +    * Added configuration schema, dependencies, and validation to maintain
           data-integrity between deployments and updates.
    

    Not added in this patch, but "data-integrity" => "data integrity".

  7. +- Made media management (a little) easier:
    

    That looks pretty odd. Why not just "Improved media management"?

  8. +    * Made it possible to use drag-and-drop for instant uploads, when using file
    +      fields. Even multiple files at once.
    

    The last sentence especially (which isn't even a sentence) seems out of place here. Maybe the whole thing could just be "Made it possible to instantly upload files via drag-and-drop"?

  9. +      * Added language fallback possibility in interface translation (no UI in
    +        core though to configure it).
    

    I found that sentence confusing. Not sure the best way to reword it, but maybe "Added a language fallback capability to the interface translation API"?

  10. +    * Added the notion of comment types (for reviews, greetings, and so on),
    +      which may take different fields on their own.
    

    Something's wrong here... at least replace the last part with "each of which can be configured with a different set of fields", I think.

  11. +    * Converted various core listings: /node, several blocks blocks,
    +      /admin/content/node and /admin/people to views.
    

    Something's wrong with that sentence... How about "Converted various core listings to views, including /node, /admin/content/node, /admin/people, and several blocks"?

  12. +    * Added ability to place all blocks multiple times.
    

    Should be "Added the ability to place all blocks multiple times on the same page"?

  13. +- Introduced an accessible modal API based on improvements made in collaboration
    +  with the jQuery UI team and the Views team.
    

    Views is part of Drupal, so "and the Views team" doesn't make any sense here. Just leave that part off.

  14. +- Moved the automated cron execution functionality to its own module, so it can
    +  be turned off on sites that don't need it.
    

    It was always possible to turn off...

    "Moved the automated cron execution functionality to its own module" is enough to say here by itself, I think.

  15. +    * Managing fields for each entity type is now a separate (secure)
    +      permission.
    

    "Secure" is really ambiguous here. I would just leave that word out.

  16. +    * PDO MySQL limited to executing single statements to limit SQLi vectors.
    

    This should not be here since it wasn't introduced in Drupal 8 (see http://cgit.drupalcode.org/drupal/tree/CHANGELOG.txt?h=7.40#n53). However given #2489672: Limit all DB drivers to executing single statements by checking for delimiter this could instead maybe say something about adding similar protection for non-MySQL drivers?

    Also, "SQLi" => "SQL injection".

  17. +    * Twig autoescape to provide output-filtering and prevent XSS vectors.
    

    Let's be careful with this one. We don't autoescape everything, and what we do isn't limited to Twig. I would say something like "Added an autoescape API to prevent cross-site scripting in many of the places where Drupal outputs HTML"...

  18. +    * Core JavaScript API Compatible with CSP.
    

    Too much capitalization; not enough words :) How about something like "Made the core JavaScript API compatible with Content Security Policy (CSP)"?

  19. +- Security improvements:
    ....
    +    * User content entry and filtering improved, and more tightly integrated
    +      with WYSIWYG editors.
    

    Not sure what this refers to security-wise... probably needs to be more specific if it's going to stay in this section.

  20.  Drupal 8.0.x, xxxx-xx-xx (development version)
    ...
    +  months in 8.1, 8.2, etc.
     
     Drupal 7.0, 2011-01-05
    

    Hm, I guess it's time to revive #1762708: Update CHANGELOG.txt to contain up-to-date entries from previous versions of Drupal also.

Gábor Hojtsy’s picture

Status: Needs work » Needs review
FileSize
14.64 KB
7 KB

@David: Thanks for the review. Done all the things with these notes:

8. Changed that to "Made file uploads immediate when selecting files in file fields.". As @wimleers pointed out, it is not really drag and drop specific.
9. Ok, done. Once we put it that way, it also needs to move to the API section of the multilingual section :)
19. Removed. It is also in the authoring experience section with different wording, so we don't need to duplicate it.

DID NOT do these:

2. Not sure adding it above 8.0.0 would be useful, it is not really an over-arching improvement, you cannot learn much about Drupal 7 or 6 changes with change notices, they were mostly used for Drupal 8. I can remove it if its out of place. YesCT suggested it.
4. But they don't look bad on other displays :) They look good ALSO on retina displays.
12. No, its not about the same page. You can place a block to a sidebar on one page or set of pages while the same block may be in the footer on another set of pages page.
20. Indeed, different issue :)

Wim Leers’s picture

+++ b/core/CHANGELOG.txt
-- Made media management (a little) easier:
-    * Made it possible to use drag-and-drop for instant uploads, when using file
-      fields. Even multiple files at once.
+    * Made file uploads immediate when selecting files in file fields.

Thanks, this is more accurate. But it's still worth calling out the support for uploading multiple files simultaneously!

Gábor Hojtsy’s picture

Added that back.

Gábor Hojtsy’s picture

Addressed #58 which was the only one outstanding. Thanks @catch!

Any other reviews, concerns, feedback? Missing items? Things to reorganize? :) I ran out of lists and things to look at. Compared this to the D8 slideshow at drupal.org/8, to the feature list at https://www.drupal.org/drupal-8.0/features, to Dries' Prague keynote, where he cited several features, to the major/critical feature requests list that YesCT provided, against the list of removed and added modules (and the modules themselves in Drupal 8). Not sure where else to look for things we missed or if someone has stuff in mind we don't have yet? :) Not that I don't think the existing set of things is not a mind-blowing collection, just want to make sure we give the chance for all the things :)

YesCT’s picture

I'll review this now. (maybe we can get another intermediate commit)

David_Rothstein’s picture

  1. 2. Not sure adding it above 8.0.0 would be useful, it is not really an over-arching improvement, you cannot learn much about Drupal 7 or 6 changes with change notices, they were mostly used for Drupal 8.

    There are some for Drupal 7; however my bigger point is that it applies to future releases also (e.g. 8.0.1 and beyond). There is nothing about change notices that is specific to the 8.0.0 release so it looks pretty out of place to me there.

  2. 4. But they don't look bad on other displays :) They look good ALSO on retina displays.

    Honestly I don't think anyone would be confused by that - it's not like we'd want to make them worse elsewhere :) I guess it's OK as is, but I did find the "too" to be confusing.

  3. 12. No, its not about the same page. You can place a block to a sidebar on one page or set of pages while the same block may be in the footer on another set of pages page.

    Hm, right. So how about "Added the ability to place the same block in multiple locations" or something like that?

  4. +    * Made file uploads immediate when selecting files in file fields.
    

    This isn't as good as the previous one, in my opinion. It is still worth mentioning drag-and-drop even though it's not the only way. How about something like "Made it possible to instantly upload files, including via drag-and-drop"?

  5. -- Removed the Statistics module's accesslog functionality and reports from core.
    +- Improved the statistics module:
    +    * Made view counting work with the page cache and reverse proxies.
    +    * Removed the accesslog functionality and reports.
    

    "statistics" => "Statistics", but also... isn't that new (first) bullet point referring to #1209532: Count node views via AJAX in the statistics module which is already in Drupal 7? I think the only difference is that it's on by default in Drupal 8 (but not Drupal 7). Not sure that difference is really worth mentioning.

effulgentsia’s picture

Issue tags: +8.0.0 target

We're in the final home stretch of preparing 8.0.0, and we won't be committing the majority of "rc target" issues any more, but still leaving the tag on them to triage them for patch-release or minor-release post 8.0.0 release. Meanwhile, switching to "8.0.0 target" for issues we'd still love to get in before 8.0.0.

Gábor Hojtsy’s picture

@David: re #67:

1. This update is for the 8.0 release. We can and should update it for further releases in which case we could reword this. I don't think moving it out of the 8.0 section without additional explanation would work. It would need to explain how it mostly applies to Drupal 8 and only somewhat to 7 but not to anything before it. Let's remove it then.

2. Let's leave it then? I think its a good sign if we show that we do think of the non-retina, not-latest, not-enterprise, etc. :)

3. Done.

4. We had a lengthy argument about this with @WimLeers in the morning. His point was that drag and drop was not made any better and especially not *introduced* in D8, its a browser feature. That the file field works with drag and drop is not a Drupal feat it was already in the browser. (You can drag and drop a file into a D7 file field too, but it will not upload automatically). D8 made automated upload and multiple file upload support available but not the drag and drop. Also as for your suggestion its not like we made it possible to immediately upload the file, its the only way that it works now. Its not a possibility, its how it is. I think "Made it possible to instantly upload files" (your suggestion) suggests that it may be uploading instantly or maybe not (depending on configuration or PHP code or something). So for now removed the repetition of "file, file, file" there.

5. Rolled that back then (except removed "from core" because all the changes are core).

YesCT’s picture

  1. +++ b/core/CHANGELOG.txt
    -- Improved entity system.
    +    * Added support for widgets, formatters and translation to base entity
    
    -- Configuration:
    +    * Made uploading, aligning and captioning of images possible in the editor.
    

    oxford comma here also.

  2. +++ b/core/CHANGELOG.txt
    -- Configuration:
    +    * Allowed module authors to provide configuration in a standard file format.
    

    standard file format.

    "standard"

    maybe simple instead or just take out the adjective.

  3. +++ b/core/CHANGELOG.txt
    -- Configuration:
    +    * Implemented functionality to get, set, add and remove configuration.
    

    comma after add (before and)

  4. +++ b/core/CHANGELOG.txt
    -- Configuration:
    +    * Added Text Editor module to help map other editors to text formats.
    

    adding "the" so: "Added the Text Editor module"

  5. +++ b/core/CHANGELOG.txt
    -- Configuration:
    +    * Added ability to configure when unused files get deleted with the option
    +      to keep them. Useful for media libraries.
    

    fix english a bit so is a sentence.

  6. +++ b/core/CHANGELOG.txt
    -- Removed the Statistics module's accesslog functionality and reports from core.
    +- Improved the statistics module:
    

    keeping the capital on the module name.

  7. +++ b/core/CHANGELOG.txt
    -- When using MySQL, the MyISAM engine is no longer supported.
    +      and instantly, including reverse proxies and CDNs.
    

    including on
    including for
    ?

  8. +++ b/core/CHANGELOG.txt
    -- When using MySQL, the MyISAM engine is no longer supported.
    +      also enabled it by default.
    

    I think we can remove also.

YesCT’s picture

I'll make those changes now.

YesCT’s picture

I looked at the whole patch, and the changes mostly look accurate and the wording is good.

someone please check my interdiff.

I dont think it is ok to have a changelog and not have a pointer to where people can actually find all of the changes: the change records.
How are people supposed to discover our change records?

But we can discuss that later, I'm ok with a commit without it.

YesCT’s picture

based on feedback from @dawehner in irc (standard YAML redundant), so taking out the standard and being specific about which standard. :)

David_Rothstein’s picture

-
-The following is a list of the most important changes made to Drupal in 8.0.0.
-For a detailed list of changes with background information, see
-https://www.drupal.org/list-changes/drupal
-

How about instead of that "intro", just add a single bullet point at the bottom?

- Numerous other important changes and additions. See https://www.drupal.org/list-changes/drupal for a detailed list.

The problem is still that that link isn't (and never will be) specific to 8.0.0 but at least that would get it into the list, in a way that's consistent with the "catch-all" bullets points at the bottom of existing CHANGELOG.txt entries.

In fact we could add those catch-all bullet points too (certainly they are true), so maybe:

...
- Numerous other important changes and additions. See https://www.drupal.org/list-changes/drupal for a detailed list.
- Numerous bug fixes.
- Numerous API documentation improvements.
- Additional automated test coverage.
tim.plunkett’s picture

* All entity types, not just nodes, now have support for revisions.

Wishful thinking, sadly. Only applies to content entity types.

YesCT’s picture

I'll make those change now.

(maybe when after some change record improvements we can have a link that applies a filter by version that is useful. right now... it's not so much)

YesCT’s picture

YesCT’s picture

here is the meta I was thinking of: #2292469: [meta] Improve change records
and this child might be the one that would result in an argument to the url for change records where a version can be given: #2289073: Make it easier to find change records that are relevant for major version upgrades

YesCT’s picture

+++ b/core/CHANGELOG.txt
@@ -52,7 +52,8 @@ Drupal 8.0.x, xxxx-xx-xx (development version)
+    * All content entity types (terms, comments, etc.), not just nodes, have
+      support for revisions.

we could add custom blocks to the list before the etc.

larowlan’s picture

we could add custom blocks to the list before the etc.

yeah cause only nodes and custom blocks are turned on by default

plach’s picture

  1. +++ b/core/CHANGELOG.txt
    @@ -10,7 +11,7 @@ Drupal 8.0.x, xxxx-xx-xx (development version)
         * Included the HTML5 Shiv library to support HTML5 elements in IE 8 and
    
    @@ -29,41 +31,70 @@ Drupal 8.0.x, xxxx-xx-xx (development version)
         * Removed most support for Internet Explorer 8 and below.
    

    These two look weird in combination.

  2. +++ b/core/CHANGELOG.txt
    -- Improved entity system.
    +- Improved the entity system:
    

    I may be biased but shouldn't we mention that the entity schema is now fully managed by the system? ;)

YesCT’s picture

Thanks @larowlan and @plach
I'm going to make a new patch now.

YesCT’s picture

Added the custom blocks.

I checked "Included the HTML5 Shiv library" was an old entry (the line was moved around in this issue in an earlier commit). I think it makes most sense to remove it given we are removing IE 8 support.

got help from @alexpott and @catch for the wording of the entity schema line. thanks!

let's get this a review!

plach’s picture

Thanks, this looks ready to go to me, but I have not enough knowledge about all the D8 changes to RTBC it.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

You know, we can iterate for ages, let's get the improvements in!

  1. +++ b/core/CHANGELOG.txt
    -- Improved entity system.
    +    * Added search to the module listing and made the page easier to read.
    

    I was about to mention that we could add that you can also search on the testing page, but this is not strictly a site administrator experience ;)

  2. +++ b/core/CHANGELOG.txt
    -- Reworked menu links, local actions, and local tasks based upon the new routing
    +- Made declarative information (libraries, permissions, routes etc.) use YAML
    +  files for definitions instead of PHP.
    

    Maybe also mention menu links?

YesCT’s picture

Status: Needs work » Reviewed & tested by the community

testbot just retested all the patches when the change went to rtbc... [edit: those interested might want to see #2598438: Improve logic and/or UI around retesting patches in RTBC issues and patches can be hidden as a workaround]

the fail on #83 can't be failing cause of changes to changelog.
https://www.drupal.org/pift-ci-job/84616
head: https://www.drupal.org/pift-ci-job/84336 was earlier
and there haven't been any commits since then.
so I'm gonna reset this to rtbc.

tim.plunkett’s picture

YesCT’s picture

Thanks @tim.plunkett for hiding the old patches so they are not retested and for removing allll the test fail messages on the old patches that are not relevant :)

effulgentsia’s picture

This looks great. Thanks for everyone's contribution to this! Ticking everyone's credit box but mine.

  • effulgentsia committed 54ce503 on 8.0.x
    Issue #2606334 by Gábor Hojtsy, YesCT, dawehner, Cottser, larowlan, Wim...
effulgentsia’s picture

I pushed #83 to 8.0.x. But before marking this Fixed, here's a patch to set the exact version and date. Just uploading it as a reminder for @catch to do this prior to tagging.

David_Rothstein’s picture

He'll probably want to look at https://www.drupal.org/node/721106 for that :)

  • catch committed 35c2f3c on 8.0.x
    Issue #2606334 by Gábor Hojtsy, YesCT, dawehner, Cottser, larowlan, Wim...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed 35c2f3c on 8.1.x
    Issue #2606334 by Gábor Hojtsy, YesCT, dawehner, Cottser, larowlan, Wim...
  • effulgentsia committed 54ce503 on 8.1.x
    Issue #2606334 by Gábor Hojtsy, YesCT, dawehner, Cottser, larowlan, Wim...
  • catch committed 645e7f9 on 8.1.x
    Issue #2606334 by Gábor Hojtsy, Cottser, dawehner, Wim Leers,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.