Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The following issues need to be fixed:
Snake_case for declaring public properties.property inherited from parent plugin- Absence of documentation for some methods. - added in #12
- Unnecessary braces ($clause declaration).
- Meaningless variable names ($ces).
Comment | File | Size | Author |
---|---|---|---|
#21 | 2605714-21.patch | 3.95 KB | Utkarsh_Mishra |
#17 | 2605714-interdiff-16.txt | 1000 bytes | andypost |
#16 | 2605714-interdiff-12.txt | 1020 bytes | andypost |
Comments
Comment #2
Chi CreditAttribution: Chi commentedPostpone this till #2591147: Filter criteria for views, option "Content is updated" - causes a SQL syntax error is fixed to prevent broken patches.
Comment #3
Chi CreditAttribution: Chi commentedComment #4
Chi CreditAttribution: Chi commentedComment #5
Chi CreditAttribution: Chi commentedComment #11
andypostComment #12
andypostChecked state, both field & filter needs fixes
#1 removed cos no longer here
#2 can't be fixed because inherited
#3 doc blocks fixed
Comment #13
andypostComment #14
idebr CreditAttribution: idebr at ezCompany commentedPoint 3 and 4 from the issue summary have yet to be addressed. These points target these lines in ./core/modules/history/src/Plugin/views/filter/HistoryUserTimestamp.php
Comment #15
andypostI'm not sure it is good idea to change
ces
to anything else because all over in comment module we use this abbreviation forcomment_entity_statistics
Comment #16
andypostFixed #3 and still prefer not fix
$ces
cos it common all over core codeComment #17
andypostAh it's about variable name, then makes sense
Comment #18
pifagorLook good
Comment #19
borisson_All of the issues mentioned in the IS are now fixed. Looks like a good improvement.
Comment #20
alexpottMixing inheritdoc with extra docs is not supported as far as I know. Given that the docs on the parent are
Disable the possibility to use operators.
I think the extra docs are either redundant or moved to the parent.Comment #21
Utkarsh_Mishra CreditAttribution: Utkarsh_Mishra at OpenSense Labs for DrupalFit commentedComment #22
andypostlet's go without comment
Comment #23
alexpottGave @idebr a review credit for ensuring the issue summary was carried out. And @Chi a credit for credit the issue with a clear instruction of what to do.
Backported to 8.5.x because there is no change here and 90% docs. So handy to keep everything in sync.