Trigger tests fail [#260501]

363 passes, 5 fails and 10 exceptions.

Check to make sure the unpublish post action can be unassigned from the trigger. at [/Applications/MAMP/htdocs/head/modules/trigger/trigger.test line 65] [Other] Fail
Check to make sure the make post sticky action can be unassigned from the trigger. at [/Applications/MAMP/htdocs/head/modules/trigger/trigger.test line 65] [Other] Fail
Check to make sure the make post unsticky action can be unassigned from the trigger. at [/Applications/MAMP/htdocs/head/modules/trigger/trigger.test line 65] [Other] Fail
Check to make sure the promote post to front page action can be unassigned from the trigger. at [/Applications/MAMP/htdocs/head/modules/trigger/trigger.test line 65] [Other] Fail
Check to make sure the remove post from front page action can be unassigned from the trigger. at [/Applications/MAMP/htdocs/head/modules/trigger/trigger.test line 65] [Other] Fail
Unexpected PHP error [Table 'head.simpletest512127watchdog' doesn't exist query: INSERT INTO simpletest512127watchdog (uid, type, message, variables, severity, link, location, referer, hostname, timestamp) VALUES (1, 'actions', 'Action \'%%action\' added.', 'a:1:{s:7:\"%%action\";s:17:\"Unpublish comment\";}', 5, '', 'http://localhost/head/admin/build/testing', 'http://localhost/head/admin/build/testing', '::1', 1211259942)] severity [E_USER_WARNING] in [/Applications/MAMP/htdocs/head/includes/database.mysqli.inc line 130] [PHP] Exception
Unexpected PHP error [Table 'head.simpletest512127watchdog' doesn't exist query: INSERT INTO simpletest512127watchdog (uid, type, message, variables, severity, link, location, referer, hostname, timestamp) VALUES (1, 'actions', 'Action \'%%action\' added.', 'a:1:{s:7:\"%%action\";s:12:\"Publish post\";}', 5, '', 'http://localhost/head/admin/build/testing', 'http://localhost/head/admin/build/testing', '::1', 1211259942)] severity [E_USER_WARNING] in [/Applications/MAMP/htdocs/head/includes/database.mysqli.inc line 130] [PHP] Exception
Unexpected PHP error [Table 'head.simpletest512127watchdog' doesn't exist query: INSERT INTO simpletest512127watchdog (uid, type, message, variables, severity, link, location, referer, hostname, timestamp) VALUES (1, 'actions', 'Action \'%%action\' added.', 'a:1:{s:7:\"%%action\";s:14:\"Unpublish post\";}', 5, '', 'http://localhost/head/admin/build/testing', 'http://localhost/head/admin/build/testing', '::1', 1211259942)] severity [E_USER_WARNING] in [/Applications/MAMP/htdocs/head/includes/database.mysqli.inc line 130] [PHP] Exception
Unexpected PHP error [Table 'head.simpletest512127watchdog' doesn't exist query: INSERT INTO simpletest512127watchdog (uid, type, message, variables, severity, link, location, referer, hostname, timestamp) VALUES (1, 'actions', 'Action \'%%action\' added.', 'a:1:{s:7:\"%%action\";s:16:\"Make post sticky\";}', 5, '', 'http://localhost/head/admin/build/testing', 'http://localhost/head/admin/build/testing', '::1', 1211259942)] severity [E_USER_WARNING] in [/Applications/MAMP/htdocs/head/includes/database.mysqli.inc line 130] [PHP] Exception
Unexpected PHP error [Table 'head.simpletest512127watchdog' doesn't exist query: INSERT INTO simpletest512127watchdog (uid, type, message, variables, severity, link, location, referer, hostname, timestamp) VALUES (1, 'actions', 'Action \'%%action\' added.', 'a:1:{s:7:\"%%action\";s:18:\"Make post unsticky\";}', 5, '', 'http://localhost/head/admin/build/testing', 'http://localhost/head/admin/build/testing', '::1', 1211259942)] severity [E_USER_WARNING] in [/Applications/MAMP/htdocs/head/includes/database.mysqli.inc line 130] [PHP] Exception
Unexpected PHP error [Table 'head.simpletest512127watchdog' doesn't exist query: INSERT INTO simpletest512127watchdog (uid, type, message, variables, severity, link, location, referer, hostname, timestamp) VALUES (1, 'actions', 'Action \'%%action\' added.', 'a:1:{s:7:\"%%action\";s:26:\"Promote post to front page\";}', 5, '', 'http://localhost/head/admin/build/testing', 'http://localhost/head/admin/build/testing', '::1', 1211259942)] severity [E_USER_WARNING] in [/Applications/MAMP/htdocs/head/includes/database.mysqli.inc line 130] [PHP] Exception
Unexpected PHP error [Table 'head.simpletest512127watchdog' doesn't exist query: INSERT INTO simpletest512127watchdog (uid, type, message, variables, severity, link, location, referer, hostname, timestamp) VALUES (1, 'actions', 'Action \'%%action\' added.', 'a:1:{s:7:\"%%action\";s:27:\"Remove post from front page\";}', 5, '', 'http://localhost/head/admin/build/testing', 'http://localhost/head/admin/build/testing', '::1', 1211259942)] severity [E_USER_WARNING] in [/Applications/MAMP/htdocs/head/includes/database.mysqli.inc line 130] [PHP] Exception
Unexpected PHP error [Table 'head.simpletest512127watchdog' doesn't exist query: INSERT INTO simpletest512127watchdog (uid, type, message, variables, severity, link, location, referer, hostname, timestamp) VALUES (1, 'actions', 'Action \'%%action\' added.', 'a:1:{s:7:\"%%action\";s:9:\"Save post\";}', 5, '', 'http://localhost/head/admin/build/testing', 'http://localhost/head/admin/build/testing', '::1', 1211259942)] severity [E_USER_WARNING] in [/Applications/MAMP/htdocs/head/includes/database.mysqli.inc line 130] [PHP] Exception
Unexpected PHP error [Table 'head.simpletest512127watchdog' doesn't exist query: INSERT INTO simpletest512127watchdog (uid, type, message, variables, severity, link, location, referer, hostname, timestamp) VALUES (1, 'actions', 'Action \'%%action\' added.', 'a:1:{s:7:\"%%action\";s:30:\"Ban IP address of current user\";}', 5, '', 'http://localhost/head/admin/build/testing', 'http://localhost/head/admin/build/testing', '::1', 1211259942)] severity [E_USER_WARNING] in [/Applications/MAMP/htdocs/head/includes/database.mysqli.inc line 130] [PHP] Exception
Unexpected PHP error [Table 'head.simpletest512127watchdog' doesn't exist query: INSERT INTO simpletest512127watchdog (uid, type, message, variables, severity, link, location, referer, hostname, timestamp) VALUES (1, 'actions', 'Action \'%%action\' added.', 'a:1:{s:7:\"%%action\";s:18:\"Block current user\";}', 5, '', 'http://localhost/head/admin/build/testing', 'http://localhost/head/admin/build/testing', '::1', 1211259942)] severity [E_USER_WARNING] in [/Applications/MAMP/htdocs/head/includes/database.mysqli.inc line 130] [PHP] Exception

Comment	File	Size	Author
#7	trigger_tests_passing_02.patch	2.09 KB	cwgordon7
#7
#6	trigger_tests_passing_01.patch	2.06 KB	cwgordon7
#6
#5	weirdness_fixed.patch	832 bytes	cwgordon7
#5

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

boombatower CreditAttribution: boombatower commented 20 May 2008 at 17:06

Been pending for some time http://drupal.org/node/205157.

Comment #2

webchick

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick commented 20 May 2008 at 17:17

Is this a duplicate? That seems to be an issue to add tests, not fix the existing ones.

Comment #3

boombatower CreditAttribution: boombatower commented 20 May 2008 at 19:43

I am for closing the other issue and using this one.

It was, but cwgordon7 marked it as needs work and attempted to fix it. I think he ran into allot of issues and it has been lying dormant ever since. The issue for creating the test was completed so probably best to mark it closed again.

Comment #4

cwgordon7 CreditAttribution: cwgordon7 commented 20 May 2008 at 20:42

I know, this is the *weirdest* exception. For some reason the table watchdog does not exist in the new database...?

The fails all seem to be on the unassigns, I wonder if this is done correctly in the tests or if something has changed in HEAD?

Comment #5

cwgordon7 CreditAttribution: cwgordon7 commented 31 May 2008 at 02:08

File	Size
weirdness_fixed.patch	832 bytes

I figured out the weird exceptions: SimpleTest was installing the modules in the wrong order! Haha, that's funny...

Comment #6

cwgordon7 CreditAttribution: cwgordon7 commented 31 May 2008 at 03:14

Status:

Active

» Needs review

File	Size
trigger_tests_passing_01.patch	2.06 KB

Better patch. All trigger tests now pass. Review please!

Comment #7

cwgordon7 CreditAttribution: cwgordon7 commented 31 May 2008 at 04:48

File	Size
trigger_tests_passing_02.patch	2.09 KB

Er. Take two.

Comment #8

Senpai CreditAttribution: Senpai commented 31 May 2008 at 16:04

Status:

Needs review

» Reviewed & tested by the community

Tested #7 against a fresh copy of HEAD, and a virgin db. Triggers reports 368 passes, 0 fails and 0 exceptions. Success!

Comment #9

boombatower CreditAttribution: boombatower commented 31 May 2008 at 17:18

This is nit picking, but since this is different from the original code I thought I would bring it up.

Is there any reason for

$args = func_get_args();
$modules = array_unique(array_merge(drupal_verify_profile('default', 'en'), $args));

instead of

$modules = array_unique(array_merge(drupal_verify_profile('default', 'en'), func_get_args()));

Since args is never used after that.

Comment #10

cwgordon7 CreditAttribution: cwgordon7 commented 31 May 2008 at 18:39

Please see http://us3.php.net/func_get_args.

Note: Because this function depends on the current scope to determine parameter details, it cannot be used as a function parameter. If this value must be passed, the results should be assigned to a variable, and that variable should be passed.