HelpBlock has the 'url' cache context instead of 'route' [#2604098]

Problem/Motivation

url is wrong, route is correct, because HelpBlock does

$help = $this->moduleHandler->invokeAll('help', array($this->routeMatch->getRouteName(), $this->routeMatch));

Proposed resolution

Fix it.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Why during RC?

Because core setting the right example wrt cacheability metadata is important: developers will look at core's examples and learn from them, core being wrong is problematic.

Comment	File	Size	Author
#3	2604098-3.patch	2.27 KB	Wim Leers
#3	8.0.x: PHP 5.5 & MySQL 5.5 14,471 pass PHP 7 & MySQL 5.5 14,460 pass, 2 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

29 October 2015 at 10:15

Wim Leers created an issue. See original summary.

Comment #2

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers as a volunteer commented 29 October 2015 at 10:16

Issue summary:

View changes

Comment #3

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers as a volunteer commented 29 October 2015 at 10:29

Status:

Active

» Postponed

File	Size
2604098-3.patch	2.27 KB
8.0.x: PHP 5.5 & MySQL 5.5 14,471 pass PHP 7 & MySQL 5.5 14,460 pass, 2 fail

Blocked on #2541344: BlockBase subclasses should merge their cache tags/contexts with the parent's (BlockBase's) because patch is relative to that.

Comment #4

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers as a volunteer commented 29 October 2015 at 10:29

Title:

HelpBlock has the 'url' cache context instead of 'route'

» [PP-1] HelpBlock has the 'url' cache context instead of 'route'

Comment #5

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers as a volunteer commented 30 October 2015 at 17:44

Title:	[PP-1] HelpBlock has the 'url' cache context instead of 'route'	» HelpBlock has the 'url' cache context instead of 'route'
Status:	Postponed	» Needs review

#2541344: BlockBase subclasses should merge their cache tags/contexts with the parent's (BlockBase's) landed, unpostponing.

Comment #6

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers as a volunteer commented 18 January 2016 at 18:37

Issue tags:

-rc target triage

Comment #7

Fabianx CreditAttribution: Fabianx at Tag1 Consulting commented 19 January 2016 at 12:03

Status:

Needs review

» Reviewed & tested by the community

Looks good to me.

Is this really a bug fix or task for 8.1.x?

Comment #8

22 January 2016 at 18:25

Status:

Reviewed & tested by the community

» Needs work

The last submitted patch, 3: 2604098-3.patch, failed testing.

Comment #9

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers as a volunteer commented 25 January 2016 at 12:17

Status:

Needs work

» Reviewed & tested by the community

Testbot fluke.

Comment #10

26 January 2016 at 06:49

catch committed b95ae50 on 8.1.x

Issue #2604098 by Wim Leers: HelpBlock has the 'url' cache context...

But given the fix caused unrelated test failures, and that might potentially affect contrib tests too which we shouldn't unnecessarily break in patch releases, just committing to 8.1.x for now. Committed/pushed to 8.1.x, thanks!