"Only variables can be passed by reference" to file_check_directory() [#26033]

A client of mine just upgraded to the latest snapshot of PHP 5.0.5-dev and started getting errors when file_check_directory() is called:

Fatal error: Only variables can be passed by reference in c:\drupal\modules\system.module on line 653

This patch fixes the problem by assigning the values to variables before passing them to file_check_directory().

Thanks.

(BTW: I'm no longer on on drupal-devel due to time constraints.)

Comment	File	Size	Author
#8	references46.diff	4.57 KB	danielc
#8
#7	references45.diff	3.76 KB	danielc
#7
#4	modules_2.patch	4.6 KB	m3avrck
#4
#3	modules_1.patch	2.13 KB	m3avrck
#3
#2	user.module_5.patch	911 bytes	m3avrck
#2
	file_create_path.diff	2.4 KB	danielc

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

drumm

he/him

NY, US

CreditAttribution: drumm commented 16 August 2005 at 23:08

Status:

Needs review

» Reviewed & tested by the community

Patch still applies and does not cause any problems with PHP 4. I am unable to test on PHP 5.

Comment #2

m3avrck CreditAttribution: m3avrck commented 8 September 2005 at 17:45

Version:

4.6.2

» x.y.z

File	Size
user.module_5.patch	911 bytes

Confirmed, 5.0.5 final causes this fatal error: Fatal error: Only variables can be passed by reference in \drupal\modules\user.module on line 1366

Rerolled patch against latest HEAD. system.module no longer needs to be updated, only user.module does.

Comment #3

m3avrck CreditAttribution: m3avrck commented 8 September 2005 at 17:56

File	Size
modules_1.patch	2.13 KB

Correction, still applies in system.module, new patch attached.

Comment #4

m3avrck CreditAttribution: m3avrck commented 8 September 2005 at 18:13

File	Size
modules_2.patch	4.6 KB

Second and final correction, turns out there were *multiple* call by reference errors in system.module (some fixed in HEAD) others not. This patch corrects them all and correctly works with PHP 5.0.5 on second round of testing.

Comment #5

Souvent22 CreditAttribution: Souvent22 commented 8 September 2005 at 18:29

PHP Version 5.1.0b3

+1. Fixed all my errors for PHP5 regarding the "pass by refereance" error. I found 3 specific cases which generated the error, and now I have 0. Seems ready to go. For all who try this patch, please, as I did, place what version of PHP you're running, so we know it works for all 5.x.

Comment #6

Dries CreditAttribution: Dries commented 8 September 2005 at 19:46

Status:

Reviewed & tested by the community

» Fixed

Committed to HEAD. Thanks.

Comment #7

danielc CreditAttribution: danielc commented 9 September 2005 at 02:53

Status:

Fixed

» Reviewed & tested by the community

File	Size
references45.diff	3.76 KB

Attached is a patch for DRUPAL-4-5. I will attach a patch for DRUPAL-4-6 in a moment.

These patches, along with the one submitted by m3avrck, are a combination of three bug reports into one patch per branch. I will mark the following two items duplicates of this:

http://drupal.org/node/26235
http://drupal.org/node/26034