Comment pager not working in cvs? [#26031]

Comment	File	Size	Author
#5	comment.module_30.patch	1.02 KB	ixis.dylan

Comment #1

ixis.dylan CreditAttribution: ixis.dylan commented 4 July 2005 at 23:41

Can anybody confirm this? I can't find the problem.

Log in or register to post comments

Comment #2

ixis.dylan CreditAttribution: ixis.dylan commented 15 July 2005 at 12:35

Hello?

Log in or register to post comments

Comment #3

Uwe Hermann CreditAttribution: Uwe Hermann commented 23 August 2005 at 14:12

Confirmed in HEAD. The problem is here (comment.module, comment_render()):

      if ($pager = theme('pager', NULL, $comments_per_page, 0, array('comments_per_page' => $comments_per_page))) {
        $output .= $pager;
      }

The $pager variable is empty (for whatever reason), hence no pager is generated. I didn't debug this any further...

Log in or register to post comments

Comment #4

pfaocle

English

CreditAttribution: pfaocle commented 9 September 2005 at 21:11

Priority:

Normal

» Critical

Confirmed here too - can any one take a look at this?

Log in or register to post comments

Comment #5

ixis.dylan CreditAttribution: ixis.dylan commented 19 September 2005 at 15:52

Assigned:	Unassigned	» ixis.dylan
Status:	Active	» Needs review

File	Size
comment.module_30.patch	1.02 KB

Comment paging has been broken in CVS for at least 3 months, yet only one other person has noticed this?

Here's a patch to fix the bug...

Log in or register to post comments

Comment #6

tostinni CreditAttribution: tostinni commented 19 September 2005 at 17:21

I also posted a patch there.
But there's still some major bug with comments...

Log in or register to post comments

Comment #7

ixis.dylan CreditAttribution: ixis.dylan commented 19 September 2005 at 23:00

Oh, okay. I wish I'd seen your patch before I hunted this bug down myself, but thanks anyway.

You're right, the comment module is very broken right now. Most of the problems are related to the pager or the comment options box, but there are limitations with this module that are really quite suprising. Can we still not delete a single comment in a thread, for example? This is evil, and wrong.