Remove unused variable in config_translation.module module at the function ConfigTranslationDeleteForm::config_translation_config_translation_info(&$info)

CommentFileSizeAuthor
#10 2601244-9.patch1.37 KBheykarthikwithu
#8 2601244-6.patch1.57 KBheykarthikwithu
#7 2601244.patch1.57 KBheykarthikwithu
#2 2601244.patch698 bytesheykarthikwithu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

heykarthikwithu created an issue. See original summary.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented
Status: Active » Needs review
FileSize
2601244.patch698 bytes
cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Needs review » Reviewed & tested by the community

There is not much to say here.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented

yes @cilefen, thanks.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented
Issue tags: +rc eligible
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented

@heykarthikwithu can you combine #2601220: ConfigTranslationOverviewAccess::__construct docblock parameters doesn't match actual parameters and #2601228: Removal of unused variable in ConfigTranslationDeleteForm::submitForm and do these patches per module please.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented
FileSize
2601244.patch1.57 KB

yes @alexpott, both are of same module so making one patch.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented
FileSize
2601244-6.patch1.57 KB
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Needs work

Sorry @heykarthikwithu I got something wrong. This patch should only be about remove unused variables in the config_translation module.

So just combine this and #2601228: Removal of unused variable in ConfigTranslationDeleteForm::submitForm

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented
Status: Needs work » Reviewed & tested by the community
FileSize
2601244-9.patch1.37 KB

ok @alexpott :), combined both the unused variables.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 826eb45 and pushed to 8.0.x. Thanks!

  • alexpott committed 826eb45 on 8.0.x 
    Issue #2601244 by heykarthikwithu: Removal of unused variable in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.