Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
ConfigTranslationOverviewAccess::__construct
docblock parameters doesn't match actual parameters
Comment | File | Size | Author |
---|---|---|---|
#2 | 2601220.patch | 912 bytes | heykarthikwithu |
Comments
Comment #2
heykarthikwithuComment #3
tstoecklerThanks, looks good!
One note:
In general it's unnecessary to use the word "service" explicitly, because that's an implementation detail and from the point of view of ConfigTranslationOverviewAccess it's irrelevant whether the language manager is a service or not.
Don't think it's specifically wrong, though, so setting to RTBC.
Comment #4
heykarthikwithuok, thanks @tstoeckler.
Comment #5
heykarthikwithuComment #6
alexpottPlease merge with #2601244: Removal of unused variable in function config_translation_config_translation_info(&$info)
Comment #7
alexpottIgnore me I thought this was a variable remove patch... it wasn't
Comment #8
alexpottCommitted aeae48d and pushed to 8.0.x. Thanks!