ConfigTranslationOverviewAccess::__construct docblock parameters doesn't match actual parameters

CommentFileSizeAuthor
#2 2601220.patch912 bytesheykarthikwithu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

heykarthikwithu created an issue. See original summary.

heykarthikwithu’s picture

Status: Active » Needs review
FileSize
912 bytes
tstoeckler’s picture

Status: Needs review » Reviewed & tested by the community

Thanks, looks good!

One note:

+++ b/core/modules/config_translation/src/Access/ConfigTranslationOverviewAccess.php
@@ -45,6 +45,8 @@ class ConfigTranslationOverviewAccess implements AccessInterface {
+   * @param \Drupal\Core\Language\LanguageManagerInterface $language_manager
+   *   The language manager service.

In general it's unnecessary to use the word "service" explicitly, because that's an implementation detail and from the point of view of ConfigTranslationOverviewAccess it's irrelevant whether the language manager is a service or not.

Don't think it's specifically wrong, though, so setting to RTBC.

heykarthikwithu’s picture

ok, thanks @tstoeckler.

heykarthikwithu’s picture

Issue tags: +rc eligible
alexpott’s picture

Status: Reviewed & tested by the community » Closed (duplicate)
alexpott’s picture

Status: Closed (duplicate) » Reviewed & tested by the community

Ignore me I thought this was a variable remove patch... it wasn't

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed aeae48d and pushed to 8.0.x. Thanks!

  • alexpott committed aeae48d on 8.0.x
    Issue #2601220 by heykarthikwithu: ConfigTranslationOverviewAccess::...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.