Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
Later versions of Twig add a $throw parameter to Twig loaders' findTemplate() calls. Our ThemeRegistryLoader doesn't have this so it needs to be added.
Why this should be an RC target
This is not disruptive, we should do it before 8.0.0 so that we are ready to upgrade to Twig 2.x at a later time.
Per @effulgentsia in #2568181-45: [META] Update to Twig 2.x in Drupal 9:
I discussed this with the other committers, and yes to removing Drupal core usages of @deprecated Twig 1.x APIs being "rc target" material.
Proposed resolution
Add it.
Remaining tasks
Patch
Review
User interface changes
n/a
API changes
Should be none.
Data model changes
None
Comment | File | Size | Author |
---|---|---|---|
#2 | make-2600152-2.patch | 1.37 KB | star-szr |
Comments
Comment #2
star-szrComment #3
star-szrComment #4
dawehnerIts part of the twig 2.x update, so totally fine, even if for now, nothing actually pass the boolean along.
Comment #5
xjmDiscussed with @alexpott, @effulgentsia, and @catch and we agreed with this being an rc target.
Comment #6
xjmCommitted and pushed to 8.0.x. Thanks!