Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File : core/modules/toolbar/src/Tests/ToolbarAdminMenuTest.php

Found 3 unused variables.

CommentFileSizeAuthor
#2 2598500-1.patch1.19 KBkrknth
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

krknth created an issue. See original summary.

krknth’s picture

krknth CreditAttribution: krknth as a volunteer and commented
Assigned: krknth » Unassigned
Status: Needs work » Needs review
FileSize
2598500-1.patch1.19 KB

Added patch.

nicrodgers’s picture

nicrodgers
Primary language English
Location Monmouthshire, UK
CreditAttribution: nicrodgers at Welsh Government commented
Status: Needs review » Reviewed & tested by the community

patch applied cleanly to latest 8.0.x and there are no more unused variables in core/modules/toolbar/src/Tests/ToolbarAdminMenuTest.php, nice one!

  • xjm committed cd56993 on 8.0.x 
    Issue #2598500 by krknth, nicrodgers: Remove unused variables from core/...
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +rc eligible

As a coding standards cleanup, removing unused variables is rc eligible. I confirmed that all three of these local variables were never used. Committed and pushed to 8.0.x. Thanks!

krknth’s picture

krknth CreditAttribution: krknth as a volunteer and at Valuebound commented

Thanks! @nicrodgers, @xjm

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.