When switching the menu to vertical layout it becomes apparent that menu items show up twice in the markup.

CommentFileSizeAuthor
#15 admin_toolbar-menu-items-duplicated-2598136-15-8.x.patch3.23 KBmimran
#12 admin_toolbar-menu-items-duplicated-2598136-11-8.x.patch3.51 KBmimran
#8 admin_toolbar-menu-items-duplicated-2598136-8-8.x.patch3.59 KBmimran
#5 admin_toolbar-menu-items-duplicated-2598136-5-8.x.patch1.88 KBmimran
#3 2598136-3.patch435 bytesfelribeiro
duplicated_menu_items.png160.52 KBbruvers
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bruvers created an issue. See original summary.

eme’s picture

eme CreditAttribution: eme at emerya commented
Priority: Normal » Major
felribeiro’s picture

felribeiro CreditAttribution: felribeiro at CI&T commented
Status: Active » Needs review
FileSize
2598136-3.patch435 bytes

Status: Needs review » Needs work

The last submitted patch, 3: 2598136-3.patch, failed testing.

mimran’s picture

mimran CreditAttribution: mimran commented
FileSize
admin_toolbar-menu-items-duplicated-2598136-5-8.x.patch1.88 KB

Updated the patch

mimran’s picture

mimran CreditAttribution: mimran commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 5: admin_toolbar-menu-items-duplicated-2598136-5-8.x.patch, failed testing.

mimran’s picture

mimran CreditAttribution: mimran commented
FileSize
admin_toolbar-menu-items-duplicated-2598136-8-8.x.patch3.59 KB

Updated the patch to support the unit tests

mimran’s picture

mimran CreditAttribution: mimran commented
Status: Needs work » Needs review
mimran’s picture

mimran CreditAttribution: mimran commented
Status: Needs review » Needs work

The last submitted patch, 8: admin_toolbar-menu-items-duplicated-2598136-8-8.x.patch, failed testing.

mimran’s picture

mimran CreditAttribution: mimran as a volunteer commented
FileSize
admin_toolbar-menu-items-duplicated-2598136-11-8.x.patch3.51 KB

Updated the patch by removing the debug info

mimran’s picture

mimran CreditAttribution: mimran as a volunteer commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 12: admin_toolbar-menu-items-duplicated-2598136-11-8.x.patch, failed testing.

mimran’s picture

mimran CreditAttribution: mimran as a volunteer commented
FileSize
admin_toolbar-menu-items-duplicated-2598136-15-8.x.patch3.23 KB

Updated the patch to solve the test case issues

mimran’s picture

mimran CreditAttribution: mimran as a volunteer commented
Status: Needs work » Needs review
SajithAthukorala’s picture

SajithAthukorala CreditAttribution: SajithAthukorala commented
Status: Needs review » Reviewed & tested by the community

Checked with drupal version "drupal-8.0.2" and works fine for me.
patch : #15 admin_toolbar-menu-items-duplicated-2598136-15-8.x.patch

mimran’s picture

mimran CreditAttribution: mimran as a volunteer commented

Thanks @SajithAthukorala

  • matio89 committed a80432f on 8.x-1.x authored by mimran 
    Issue #2598136 by mimran, felribeiro: Menu items duplicated
mimran’s picture

mimran CreditAttribution: mimran as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.