Problem/Motivation

The date library (drupal.date) adds date.js which has a dependency to jquery.once but this is missing in the library difinition causing the JS to fail unless some other library adds jquery.once.

Proposed resolution

Add jquery.once to the dependency

Remaining tasks

Do it

User interface changes

None

API changes

None

Data model changes

None

I believe this is a zero risk task with some reward (date popup actually works for anonymous users.

CommentFileSizeAuthor
#2 2597718-1.patch321 bytesgoogletorp
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

googletorp created an issue. See original summary.

googletorp’s picture

googletorp CreditAttribution: googletorp as a volunteer and at Reveal IT commented
Status: Active » Needs review
FileSize
2597718-1.patch321 bytes

Added the patch that solves this issue.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Issue tags: +JavaScript
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler at erdfisch commented
Status: Needs review » Reviewed & tested by the community

Line 29 of date.js:

      $context.find('input[data-drupal-date-format]').once('datePicker').each(function () {

Thanks!

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Issue tags: -rc target triage +rc target

Discussed with the D8 committers and we agreed with making this an rc target.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed d9f7aa0 on 8.0.x 
    Issue #2597718 by googletorp, tstoeckler: Date library is missing...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.