Problem/Motivation

Allow profiles to provide kernel tests.

Proposed resolution

Add profiles to phpunit.xml.dist

CommentFileSizeAuthor
#9 interdiff.txt1 KBbenjy
#9 2597303-8.patch1.43 KBbenjy
phpunit.patch584 bytesbenjy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

benjy created an issue. See original summary.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented

Interesting, I would have expected that those kernel tests would be more of a module level thing, do you mind giving a concrete usecase example?

benjy’s picture

benjy CreditAttribution: benjy at PreviousNext commented

My current example is a fork of Drupal\KernelTests\Config\DefaultConfigTest specifically for testing the configuration shipped with an install profile.

It doesn't seem like something that we should restrict users from doing unless there is an unwanted side-effect? I'm sure people will come up with other genuine use cases.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Needs review » Reviewed & tested by the community

yes we can

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett as a volunteer commented
Issue tags: +rc eligible

This just concerns testing improvements.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented

@benjy
Yeah I was just primarily interested why you wanna use it ...
RTBC + 1

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Needs work

Let's make this generic and support unit tests and functional tests too

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented

Oh I would have explicitly assumed that the other ones have been supported already

benjy’s picture

benjy CreditAttribution: benjy at PreviousNext commented
Status: Needs work » Needs review
FileSize
2597303-8.patch1.43 KB
interdiff.txt1 KB

Sounds reasonable.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Thank you @benjy

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed a7212fc and pushed to 8.0.x. Thanks!

  • alexpott committed a7212fc on 8.0.x 
    Issue #2597303 by benjy: Kernel Tests should be allowed in profiles
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented

Closed duplicate #2597041: The profile dir is disabled for testing

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.