reported by merlinofchaos on IRC - for an updated 5.x-6.x site, some links give a warning. Apparently we are making one too many assumptions about what may be set in $item['attributes'].

attached (trivial) patch applies to both 6.x and 7.x

CommentFileSizeAuthor
menu-attributes-isset.patch853 bytespwolanin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented

oops make that "what is set in $item['options']"

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented

THe menu items that caused it were pre-existing items that had been moved -- in this case, node/add/story node/add/blog and node/add/page -- I had moved them all out from under create content.

This patch does appear to fix the problem.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs review » Reviewed & tested by the community
Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented
Version: 7.x-dev » 6.x-dev
Status: Fixed » Reviewed & tested by the community

should apply to 6.x too

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented

Patch applies cleanly and fixes this bug in D6.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed to Drupal 6.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.