Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
When no image style is selected for preview, the image widget is saying "Original image". This is a lie because in this case there's no preview.
Proposed resolution
Replace "Original image" with "No preview".
Remaining tasks
None.
User interface changes
The user will se the correct summary.
API changes
None.
Data model changes
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2588553-2.patch | 665 bytes | claudiu.cristea |
| widget_summary.png | 56.13 KB | claudiu.cristea | |
Comments
Comment #2
claudiu.cristeaTrivial.
Comment #3
claudiu.cristeaComment #4
yched CreditAttribution: yched commentedSure thing. I would say this is too stupid to deserve a regression test, we'll see if committers agree.
Comment #5
claudiu.cristeaFixing IS.
Comment #6
alexpottYes this is a bug but it is not RC eligible.See the allowed changes in Drupal 8 for more information.
Comment #7
alexpott@catch and i want to ask @gabor about making this type of change in RC. The string change is fixing something entirely wrong in the UI - which seems silly not to do.
Comment #8
catchSpoke to Gabor in irc, and he confirmed this is the sort of string change we should still make. i.e. we have a 'string freeze' but you wouldn't freeze meat that's already mouldy.
Comment #9
alexpottI don;t like mouldy meat. Testy manually and can confirm that no image is previewed when no preview is selected. Committed c3b76ed and pushed to 8.0.x. Thanks!